1
0
Fork 0
alistair23-linux/sound/pci
Arjan van de Ven 4b47c971dc es1968: fix sleep-while-holding-lock bug
snd_es1968_ac97_read() calls snd_es1968_ac97_wait() first outside a locked
area, and later, while holding a lock.

snd_es1968_ac97_wait() has a polling loop with a cond_resched() inside it..
which sleeps, so the second call is invalid.

This patch adds a version of the wait function that just pure polls.  While
this is not very elegant in principle, it's very likely the easiest thing to
do here, we already checked if the chip was ready (while yielding) just
before, so it is very unlikely to take a long time here.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Cc: Jaroslav Kysela <perex@suse.cz>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-08 18:25:53 -07:00
..
ac97 [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
ali5451 [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
au88x0 [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
ca0106 [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
cs46xx [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
cs5535audio [ALSA] fix cs5535 section mismatch 2008-01-31 17:30:12 +01:00
echoaudio [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
emu10k1 [ALSA] emu10k1 - Another EMU0404 Board ID 2008-01-31 17:30:25 +01:00
hda [ALSA] hda-codec - Adapt eeepc p701 mixer for virtual master control 2008-02-29 15:20:08 +01:00
ice1712 [ALSA] sound: ice1712: unused structs 2008-02-29 12:11:25 +01:00
korg1212 [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
mixart [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
nm256 [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
oxygen [ALSA] oxygen: add owner field 2008-02-29 11:28:16 +01:00
pcxhr [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
riptide [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
rme9652 [ALSA] hdsp - Fix section mismatch 2008-02-22 14:20:08 -08:00
trident [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
vx222 [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
ymfpci [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
Kconfig [ALSA] add TempoTec HiFier driver 2008-01-31 17:30:15 +01:00
Makefile [ALSA] add CMI8788 driver 2008-01-31 17:29:44 +01:00
ad1889.c [ALSA] sound: fix ad1889 section mismatch 2008-01-31 17:30:00 +01:00
ad1889.h [ALSA] ad1889: add AD1889 driver 2005-09-12 10:40:17 +02:00
als300.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
als4000.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
atiixp.c [ALSA] sound: fix atiixp section mismatch 2008-01-31 17:30:00 +01:00
atiixp_modem.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
azt3328.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
azt3328.h [ALSA] azt3328.c: small cleanup patch 2007-05-11 16:55:52 +02:00
bt87x.c [ALSA] bt87X: fix freeing of shared interrupt 2008-02-22 14:20:09 -08:00
cmipci.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
cs4281.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
cs5530.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
ens1370.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
ens1371.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
es1938.c [ALSA] es1938 - improve capture hw pointer reads 2008-01-31 17:30:23 +01:00
es1968.c es1968: fix sleep-while-holding-lock bug 2008-04-08 18:25:53 -07:00
fm801.c [ALSA] fm801 - Add mute support for FM-only card with FM801 PCI to tuner bridge 2008-01-31 17:30:14 +01:00
intel8x0.c [ALSA] intel8x0 - Add quirk for Compaq Deskpro EN 2008-02-29 15:21:27 +01:00
intel8x0m.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
maestro3.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
rme32.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
rme96.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
sis7019.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
sis7019.h [ALSA] sis7019: support the SiS 7019 Audio Accelerator 2008-01-31 17:29:36 +01:00
sonicvibes.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
via82xx.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
via82xx_modem.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00