EDAC: Fix memleak in module init error path
[ Upstream commitpull/10/head4708aa85d5
] Make sure to use put_device() to free the initialised struct device so that resources managed by driver core also gets released in the event of a registration failure. Signed-off-by: Johan Hovold <johan@kernel.org> Cc: Denis Kirjanov <kirjanov@gmail.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: linux-edac <linux-edac@vger.kernel.org> Fixes:2d56b109e3
("EDAC: Handle error path in edac_mc_sysfs_init() properly") Link: http://lkml.kernel.org/r/20180612124335.6420-1-johan@kernel.org Signed-off-by: Borislav Petkov <bp@suse.de> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
parent
a4f7bea878
commit
0c4439c444
|
@ -1097,14 +1097,14 @@ int __init edac_mc_sysfs_init(void)
|
||||||
|
|
||||||
err = device_add(mci_pdev);
|
err = device_add(mci_pdev);
|
||||||
if (err < 0)
|
if (err < 0)
|
||||||
goto out_dev_free;
|
goto out_put_device;
|
||||||
|
|
||||||
edac_dbg(0, "device %s created\n", dev_name(mci_pdev));
|
edac_dbg(0, "device %s created\n", dev_name(mci_pdev));
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
out_dev_free:
|
out_put_device:
|
||||||
kfree(mci_pdev);
|
put_device(mci_pdev);
|
||||||
out:
|
out:
|
||||||
return err;
|
return err;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue