1
0
Fork 0
remarkable-linux/drivers/scsi/bfa
Arnd Bergmann 249d9f3ef5 scsi: bfa: fix type conversion warning
commit 48d83282db upstream.

A regression fix introduced a harmless type mismatch warning:

drivers/scsi/bfa/bfad_bsg.c: In function 'bfad_im_bsg_vendor_request':
drivers/scsi/bfa/bfad_bsg.c:3137:35: error: initialization of 'struct bfad_im_port_s *' from 'long unsigned int' makes pointer from integer without a cast [-Werror=int-conversion]
  struct bfad_im_port_s *im_port = shost->hostdata[0];
                                   ^~~~~
drivers/scsi/bfa/bfad_bsg.c: In function 'bfad_im_bsg_els_ct_request':
drivers/scsi/bfa/bfad_bsg.c:3353:35: error: initialization of 'struct bfad_im_port_s *' from 'long unsigned int' makes pointer from integer without a cast [-Werror=int-conversion]
  struct bfad_im_port_s *im_port = shost->hostdata[0];

This changes the code back to shost_priv() once more, but encapsulates
it in an inline function to document the rather unusual way of
using the private data only as a pointer to the previously allocated
structure.

I did not try to get rid of the extra indirection level entirely,
which would have been rather invasive and required reworking the entire
initialization sequence.

Fixes: 45349821ab ("scsi: bfa: fix access to bfad_im_port_s")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Sasha Levin <Alexander.Levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-02-25 11:08:01 +01:00
..
Makefile
bfa.h
bfa_core.c
bfa_cs.h
bfa_defs.h
bfa_defs_fcs.h
bfa_defs_svc.h
bfa_fc.h
bfa_fcbuild.c
bfa_fcbuild.h
bfa_fcpim.c
bfa_fcpim.h
bfa_fcs.c
bfa_fcs.h
bfa_fcs_fcpim.c
bfa_fcs_lport.c
bfa_fcs_rport.c
bfa_hw_cb.c
bfa_hw_ct.c
bfa_ioc.c
bfa_ioc.h
bfa_ioc_cb.c
bfa_ioc_ct.c
bfa_modules.h
bfa_plog.h
bfa_port.c
bfa_port.h
bfa_svc.c
bfa_svc.h
bfad.c
bfad_attr.c
bfad_bsg.c scsi: bfa: fix type conversion warning 2018-02-25 11:08:01 +01:00
bfad_bsg.h
bfad_debugfs.c scsi: bfa: integer overflow in debugfs 2017-12-20 10:10:36 +01:00
bfad_drv.h
bfad_im.c scsi: bfa: fix type conversion warning 2018-02-25 11:08:01 +01:00
bfad_im.h scsi: bfa: fix type conversion warning 2018-02-25 11:08:01 +01:00
bfi.h
bfi_ms.h
bfi_reg.h