1
0
Fork 0
remarkable-linux/arch/powerpc/xmon
Anton Blanchard bc1d770291 powerpc/xmon: Use cpumask iterator to avoid warning
We have a bug report where the kernel hits a warning in the cpumask
code:

WARNING: at include/linux/cpumask.h:107

Which is:
        WARN_ON_ONCE(cpu >= nr_cpumask_bits);

The backtrace is:
        cpu_cmd
        cmds
        xmon_core
        xmon
        die

xmon is iterating through 0 to NR_CPUS. I'm not sure why we are still
open coding this but iterating above nr_cpu_ids is definitely a bug.

This patch iterates through all possible cpus, in case we issue a
system reset and CPUs in an offline state call in.

Perhaps the old code was trying to handle CPUs that were in the
partition but were never started (eg kexec into a kernel with an
nr_cpus= boot option). They are going to die way before we get into
xmon since we haven't set any kernel state up for them.

Signed-off-by: Anton Blanchard <anton@samba.org>
CC: <stable@kernel.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2012-07-02 14:30:11 +10:00
..
Makefile powerpc/Makefiles: Change to new flag variables 2010-10-13 16:19:22 +11:00
ansidecl.h powerpc: Merge xmon 2005-10-28 22:53:37 +10:00
dis-asm.h [POWERPC] Make xmon disassembly optional 2006-12-04 20:40:32 +11:00
nonstdio.c [POWERPC] fix showing xmon help 2007-07-22 21:30:58 +10:00
nonstdio.h [POWERPC] fix showing xmon help 2007-07-22 21:30:58 +10:00
ppc-dis.c [POWERPC] Import updated version of ppc disassembly code for xmon 2006-12-04 20:40:36 +11:00
ppc-opc.c bug.h: add include of it to various implicit C users 2012-02-29 17:15:08 -05:00
ppc.h [POWERPC] Import updated version of ppc disassembly code for xmon 2006-12-04 20:40:36 +11:00
spu-dis.c [PATCH] arch/powerpc trivial annotations 2007-02-09 09:14:06 -08:00
spu-insns.h [POWERPC] Import spu disassembly code into xmon 2006-12-04 20:40:29 +11:00
spu-opc.c bug.h: add include of it to various implicit C users 2012-02-29 17:15:08 -05:00
spu.h [POWERPC] Import spu disassembly code into xmon 2006-12-04 20:40:29 +11:00
start.c [POWERPC] Make xmon_write accept a const buffer 2007-07-22 21:30:58 +10:00
xmon.c powerpc/xmon: Use cpumask iterator to avoid warning 2012-07-02 14:30:11 +10:00