Commit Graph

40 Commits (d9bf9f0a4036f55411f6dfbb438990a5eb7f4930)

Author SHA1 Message Date
Adeeb d9bf9f0a40
Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
2020-05-30 20:14:58 -07:00
Jafar Al-Gharaibeh 34b9b5e849
Bounty: Mazda (#988)
* Mazda Port

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update checksum to account for steer angle signal used in some cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add test drive/segment ID to pass CI tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Process gear and brake signals, add new fingerprints

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor some car interface code

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop redundant call, use Ecu, move warning to carstate, fix cruise speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop unused variables, cleanup handsoff tracking

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update to steerError and steeringRate

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor parse gear, update lkas signals from the new dbc

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Better tracking of engage and warning events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* remove commented lines, update speed_kph to match panda

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Steer Error

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Set lkas enable speed to 52 kph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop block signal use, fix LGTM alerts

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* When gas is pressed OP will disengage, sync local state with it

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use car's speed signal instead of wheel speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Tidy up disengage events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Rebase/Refactor with upstream

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Sync stock ACC state with OP

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* mazda dbc file renamed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Improve acc stock and go by removing the 3 seconds limit

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Dashcam

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* PR Feedback

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Send ACC cancel only if we are sure cruise is enabled

Otherwise we run the risk of disabling main cruise

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* updated route

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* no process replay for now

* add to release files

* Revert "updated route"

This reverts commit 233db4f1bc2d8eefaa86488be4f6f88360d20793.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-05-28 22:15:19 -07:00
Willem Melching 3d08dcc3b2
Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
2020-05-28 15:05:04 -07:00
Adeeb c78602e8cc
Remove incomplete Hyundai Ioniq port (#1570) 2020-05-26 20:48:41 -07:00
Thaixican dd16990952
Add 2020 Lexus RX Hybrid support (#1547)
* Add 2020 Lexus RX Hybrid support

* Add 2020 Lexus RX Hybrid to IGNORED_FINGERPRINTS and route to test_car_models per @pd0wm
2020-05-26 13:49:18 -07:00
Willem Melching ef2ea14ecc add sonata 2019 to test_car_modelsg 2020-05-20 17:20:17 -07:00
Alice Knag fde1a5e9af
add support for Sonata 2019 (#1538)
* add sonata interface

update values.py

update values.py

* change sonata_1 to sonata_2019

* add sonata 2019 and forte 2019 to README

prettier fucked me up pretty hard at first
sdfsd

* update README.md

* mock test
2020-05-20 17:12:00 -07:00
Willem Melching 96605d0951 This one also needs to be fixed 2020-05-19 16:19:00 -07:00
Adeeb Shihadeh 8788ab36e4 remove those debug prints 2020-05-19 13:54:24 -07:00
Willem Melching bb8bbdd9ee
Hyundai fw query (#1540)
* hyundai fw query

* Change query

* this works

* That is not engine

* hyundai fw query

* Change query

* this works

* That is not engine

* Skip FW query in test_car_models

* Those routes don't fingerprint properly after speedup

* only send toyota queries to subaddresses

Co-authored-by: openpilot laptop <laptop@comma.ai>
2020-05-19 13:43:44 -07:00
Erich Moraga 009c32d516
Add HIGHLANDERH_TSS2 Support (#1425)
* exclude HIGHLANDERH_TSS2

* add HIGHLANDERH_TSS2 support

* Add HIGHLANDERH_TSS2 Support

* Add HIGHLANDERH_TSS2 Support

* Added to IGNORED_FINGERPRINTS per @pd0wm
2020-04-27 14:56:30 -07:00
cowanhmoore 1d6042c5f3
Honda HRV (#1404)
* PR - Honda HRV

values.py - incl. Class, FP, FW_VERSIONS, SPEED_FACTOR 1.025
carstate.py - incl. carFingerprint, doorOpen OVERRIDE (signal unknown)
Safety test concludes that removal of drivers seatbelt IMMEDIATELY disengages OP
interface.py - incl. HR-V vehicle parameters, tuning (tested for 100+ miles)
Longitudinal tuning parameters unchanged from CAR.FIT
test_car_models.py - added per request of review process
*5. honda_hrv_touring_2019_can_generated.dbc will be submitted to commaai/opendbc in next PR

Once *5 is approved, will need to update values.py to matching dbc

Thanks, Cowan Moore 330-701-3922

* Honda HRV Door Signal

BO_ 422 SCM_BUTTONS: 8 SCM
 SG_ DRIVERS_DOOR_OPEN : 63|1@0+ (1,0) [0|1] "" EON

* Update values.py

* Update test_car_models.py
2020-04-20 15:30:46 -07:00
Willem Melching ed527dfd1e Add Palisade to test_car_models 2020-04-17 11:46:16 -07:00
Willem Melching 7d78cef34b
Hyundai-Kia-Genesis (HKG) (#1362)
* hkg

* Cleanup

* Update readme

* more fixes and cleanup

* Old genesis

* Typoe

* Test car models

* Update comment

* Fix brake pressed

* Update release notes

* Fix vEgo

* Add sonata

* Add sonata values

* Temporarily remove doors check. It doesn't work

* Sonata uses crc8

* Fix tests

* Changes for LFA

* Add comment

* Does this improve the hud?

* Proper signal name

* Force the right value

* some ui stuff

* more comments

* Show lane lines on sonata

* cleanup dash

* fix last ui issues

* Fix doors

* update CI

Co-authored-by: Comma Device <device@comma.ai>
2020-04-15 19:33:24 -07:00
Adeeb e22482eb31
Remove Cadillac CT6 port (#1359)
* remove CT6 port

* dont need this route

* extra char

* fix carcontroller params
2020-04-13 15:53:24 -07:00
Willem Melching 746f7ed9b1
2020 Chrysler Pacifica (#1297)
* 2020 pacifica support

* Update readme
2020-03-31 15:47:49 -07:00
Willem Melching 1df6b67511
Nissan leaf (#1275)
* split out leaf and xtrail

* Add brake pedal

* This should work

* Fix test car models + bump panda

* Combined cruise enabled detection in single message

* Proper frequency checks

* Add doors

* Blinkers and doors

* Seatbelt

* Gear

* Add cancel message

* Unify steering pressed

* Remove angle limit

* Add steer saturation alert for angle based control

* Add set speed

* Change wheel speed factor

* Fix offset in set speed

* Timeout on engage for steer saturated

* Put counter back

* try cancel using seatbelt

* Try different cancel message

* Rename cancel signal

* Add LKAS alert

* Add missing fingerprint values

* Update test car models

* Add some comments
2020-03-27 21:44:59 -07:00
Chris Souers 035397cd31
Adds 2016 CR-V Executive (Euro version of Touring trim) (#1097)
Co-authored-by: Ted Slesinski <ted_slesinski@epam.com>
2020-03-13 11:48:08 -07:00
Willem Melching 768f08e129 add honda pilot 2019 to test car models 2020-03-11 16:51:45 -07:00
Willem Melching fbac82ea21 add accord 1.5L to test_car_models 2020-03-07 11:05:46 -08:00
Willem Melching 82f77e379b add crv5g and optima to test_car_models 2020-03-06 17:33:30 -08:00
Willem Melching 3d15eb39d5 Add 2017 Pacifica Hybrid to test_car_models 2020-03-06 17:13:09 -08:00
Willem Melching a25acaae07
More public routes in test car models (#1208)
* remove non public routes

* Fix linter

* add rav4h

* add odyssey

* add pilot and civic_bosch

* cth and camry

* add regal
2020-03-06 13:44:34 -08:00
Willem Melching 6db044c86c
Nissan port - dashcam only (#1203)
* Nissan port

* add x-trail to release notes

* update readme and model

* remove from releases until tested

* Don't test Nissan for now

* Forced dashcam in test_car_models
2020-03-05 15:40:07 -08:00
theantihero c8c4708f21
Add 2019 Honda Insight (#1166)
* add 2019 Honda Insight + fw fp

* add actual fp and add to ignored, but still required for ECU detection

* add Insight dirty route for now

* update README.md, was wrong mph for each

* update test_car_models

* remove dbc extension
2020-02-27 14:56:36 -08:00
Chris Souers ba6f555ede
Add support for 2019 Civic Sedan 1.6L Diesel with CVT (#1091)
add car

Update test_car_models.py

Update test_car_models.py

add firmware

Update README.md

Update test_car_models.py
2020-02-21 11:03:10 -08:00
Willem Melching fdbe289e71
Add HONDA.ACCORDH to test_car_models (#1143)
Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
2020-02-20 16:23:29 -08:00
Willem Melching 85e8bb90d4
Merge 2019 and 2020 Chrysler Pacifica Hybrid (#1142)
* Merge 2019 and 2020 Chrysler Pacifica Hybrid

* fix carcontroller
2020-02-20 16:23:10 -08:00
Willem Melching 9e6e1cba56
Fingerprint rav4 hybrid tss2 only using firmware versions (#1084)
* fingerprint rav4 hybrid tsss only using firmware

* remove print statement
2020-02-12 12:59:38 -08:00
Patipat Susumpow 576317ad10
Add support for Lexus NX 300h 2018 (#1077)
* Add support for Lexus NX 300h 2018

* Add Lexus NX 300h 2018 to README.md

* Fix a misplaced value CAR.LEXUS_NXH in the values.py
2020-02-11 19:27:17 -08:00
che220 4ea7294607
2020 Toyota Highlander (TSS2) (#1065)
* added 2020 highlander (TSS2)

* add HIGHLANDER_TSS2 test into routes

* reduce HIGHLANDER_TSS2 weight to 4700 from 4900

* add highlander 2020 limited to the list of supported cars
2020-02-11 11:06:50 -08:00
Adeeb 30dffb486a
test car models: fix random hanging (#1055)
* debug print

* unlogger doesn't need fcamera.hevc

* only need the rlog

* tiemout for log downloading

* try again after timeout
2020-02-06 10:53:59 -08:00
illumiN8i 39c9c85562
2020 Lexus RX 350 (#1046)
* Lexus RX 2020

* Update test_car_models.py
2020-02-03 10:12:13 -08:00
Drew Hintz 5aff2b6885
support for Chrysler Pacifica 2020 Hybrid (#1021)
* support for Chrysler Pacifica 2020 Hybrid
Thanks to Benson in Discord.
Example segment: 8190c7275a24557b|2020-01-29--08-33-58--7

* Add relevant route to selfdrive/test/test_car_models.py

* fix segment test name
2020-02-03 09:17:45 -08:00
George Hotz c42e2ecc50
manager runs on Mac, and other openpilot for PC fixes (#1037)
* use the openpilot/persist directory on PC

* manager runs on mac

* sim runs w/o carla

* fix params location in test

* that rmtree can fail and it's okay

* refactor params clear functionality

* set PARAMS_PATH
2020-02-02 12:15:02 -08:00
Adeeb d4c3c7f6f8
test_car_models: fail if a model has no routes (#1029) 2020-02-01 18:41:25 -08:00
illumiN8i 3ebb0bc46f
Lexus RX 2016-2017 (#1001)
fix dbc name

Add Lexus RX to test_car_models.py

correct route in Lexus RX test

Update test_car_models.py
2020-01-30 13:32:30 -08:00
illumiN8i 21af1bad2b RAV4 Hybrid TSS2 Support (#962)
* merge wocsor RAV4_HYBRID_TSS2 branch

From wocsor's PR #740

cleanup fingerprint

2020 rav4 hybrid confirmed working

* 2019 RAV4 Hybrid Limited

Adds additional messages for Limited trim. XSE and XLE still contained within this longer Limited fingerprint.

* Support Swiss 2019 RAV4 Hybrid XLE

Adds 913:8 value from discord user RDuke

* Separated RAV4 ICE and Hybrid

* Add route to test_car_models.py

* Revert "Toyota Corolla Hatchback Hybrid 2019 Excite (Israel)"

This reverts commit f1d6f68625.
2020-01-23 16:48:01 -08:00
Adeeb 87f9e14e9c speed up car model test (#977) 2020-01-20 12:56:14 -08:00
George Hotz c0bfbc12c7 selfdrive/test 2020-01-17 11:16:14 -08:00