Start tests for UI component

webpack/sequences/step_tiles/mark_as/__tests__/action_list_test.ts

@@ -1,27 +1,13 @@
 import { actionList, PLANT_OPTIONS } from "../action_list";
-import { betterMerge } from "../../../../util";
-import { resourceUpdate } from "../assertion_support";
-import {
-  fakeTool,
-  fakePlant,
-  fakePoint
-} from "../../../../__test_support__/fake_state/resources";
+import { resourceUpdate, markAsResourceFixture } from "../assertion_support";
 import {
   buildResourceIndex
 } from "../../../../__test_support__/resource_index_builder";
 
 describe("actionList()", () => {
-  const myIndex = () => buildResourceIndex([
-    betterMerge(fakeTool(), { body: { name: "T1", id: 1 } }),
-    fakePlant(),
-    betterMerge(fakeTool(), { body: { name: "T2", id: 2 } }),
-    betterMerge(fakePoint(), { body: { name: "my point", id: 7 } }),
-    betterMerge(fakeTool(), { body: { name: "T3", id: undefined } }),
-  ]);
-
   it("uses args.resource_type if DropDownItem is undefined", () => {
     const step = resourceUpdate({ resource_type: "Plant" });
-    const { index } = myIndex();
+    const { index } = markAsResourceFixture();
     const result = actionList(undefined, step, index);
     expect(result).toEqual(PLANT_OPTIONS);
   });
@@ -29,7 +15,7 @@ describe("actionList()", () => {
   it("provides a list of tool mount actions", () => {
     const ddi = { label: "test case", value: 1, headingId: "Device" };
     const step = resourceUpdate({});
-    const { index } = myIndex();
+    const { index } = markAsResourceFixture();
     const result = actionList(ddi, step, index);
     expect(result.length).toBe(3);
     const labels = result.map(x => x.label);
@@ -41,7 +27,7 @@ describe("actionList()", () => {
   it("provides a list of generic pointer actions", () => {
     const ddi = { label: "test case", value: 1, headingId: "GenericPointer" };
     const step = resourceUpdate({});
-    const { index } = myIndex();
+    const { index } = markAsResourceFixture();
     const result = actionList(ddi, step, index);
     expect(result.length).toBe(1);
     const labels = result.map(x => x.label);

webpack/sequences/step_tiles/mark_as/__tests__/resource_list_test.ts

@@ -1,7 +1,14 @@
+import { resourceList } from "../resource_list";
+import { markAsResourceFixture } from "../assertion_support";
 
 describe("resourceList()", () => {
   it("lists defaults, plus saved points", () => {
-    expect(2 + 2).toBe(4);
-    // fail("BRB");
+    const { index } = markAsResourceFixture();
+    const result = resourceList(index);
+    expect(result.length).toBeTruthy();
+    const headings = result.filter(x => x.heading).map(x => x.label);
+    expect(headings).toContain("Device");
+    expect(headings).toContain("Plants");
+    expect(headings).toContain("Points");
   });
 });

webpack/sequences/step_tiles/mark_as/assertion_support.ts

@@ -1,4 +1,13 @@
 import { ResourceUpdate } from "farmbot";
+import {
+  buildResourceIndex
+} from "../../../__test_support__/resource_index_builder";
+import {
+  fakeTool,
+  fakePlant,
+  fakePoint
+} from "../../../__test_support__/fake_state/resources";
+import { betterMerge } from "../../../util";
 
 type Args = Partial<ResourceUpdate["args"]>;
 
@@ -14,3 +23,11 @@ export function resourceUpdate(i: Args): ResourceUpdate {
     }
   };
 }
+
+export const markAsResourceFixture = () => buildResourceIndex([
+  betterMerge(fakeTool(), { body: { name: "T1", id: 1 } }),
+  fakePlant(),
+  betterMerge(fakeTool(), { body: { name: "T2", id: 2 } }),
+  betterMerge(fakePoint(), { body: { name: "my point", id: 7 } }),
+  betterMerge(fakeTool(), { body: { name: "T3", id: undefined } }),
+]);

webpack/sequences/step_tiles/mark_as/resource_list.ts

@@ -42,10 +42,10 @@ export const pointer2ddi = (i: GenericPointer): DropDownItem => {
 
 export const plant2ddi = (i: TaggedPlantPointer["body"]): DropDownItem => {
   const { x, y, z, name, id } = i;
-  const n = name || i.openfarm_slug || `Plant ${id}`;
+
   return {
-    value: i.id as number,
-    label: `${n} (${x}, ${y}, ${z})`,
+    value: id as number,
+    label: `${name} (${x}, ${y}, ${z})`,
     headingId: "Plant"
   };
 };