spacecruft
/
Farmbot-Web-App
1
0
Fork 0
Code Issues Pull Requests Releases Activity

Update some default values (#956) 

* Default movement_keep_active_* to `1`
* Enable encoders by default
pull/957/head
Rick Carlino 2018-08-13 15:34:19 -05:00 committed by GitHub
parent 2caa1684d6
commit 92d8f7fc18
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 25 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
db/migrate/20180813185430_always_power_xyz.rb 100644
View File

@ -0,0 +1,12 @@
class AlwaysPowerXyz < ActiveRecord::Migration[5.2]
def change
fc = :firmware_configs
change_column fc, :encoder_enabled_x, :integer, default: 1
change_column fc, :encoder_enabled_y, :integer, default: 1
change_column fc, :encoder_enabled_z, :integer, default: 1
change_column fc, :movement_keep_active_x, :integer, default: 1
change_column fc, :movement_keep_active_y, :integer, default: 1
change_column fc, :movement_keep_active_z, :integer, default: 1
end
end

13
db/structure.sql
View File

@ -377,9 +377,9 @@ CREATE TABLE public.firmware_configs (
device_id bigint,
created_at timestamp without time zone NOT NULL,
updated_at timestamp without time zone NOT NULL,
encoder_enabled_x integer DEFAULT 0,
encoder_enabled_y integer DEFAULT 0,
encoder_enabled_z integer DEFAULT 0,
encoder_enabled_x integer DEFAULT 1,
encoder_enabled_y integer DEFAULT 1,
encoder_enabled_z integer DEFAULT 1,
encoder_invert_x integer DEFAULT 0,
encoder_invert_y integer DEFAULT 0,
encoder_invert_z integer DEFAULT 0,
@ -419,8 +419,8 @@ CREATE TABLE public.firmware_configs (
movement_invert_motor_x integer DEFAULT 0,
movement_invert_motor_y integer DEFAULT 0,
movement_invert_motor_z integer DEFAULT 0,
movement_keep_active_x integer DEFAULT 0,
movement_keep_active_y integer DEFAULT 0,
movement_keep_active_x integer DEFAULT 1,
movement_keep_active_y integer DEFAULT 1,
movement_keep_active_z integer DEFAULT 1,
movement_max_spd_x integer DEFAULT 400,
movement_max_spd_y integer DEFAULT 400,
@ -2303,6 +2303,7 @@ INSERT INTO "schema_migrations" (version) VALUES
('20180720021451'),
('20180726145505'),
('20180726165546'),
('20180727152741');
('20180727152741'),
('20180813185430');

1
lib/tasks/typescript.rake
View File

@ -8,6 +8,7 @@ class Typescript
"integer" => "number",
"timestamp without time zone" => "string",
"character varying" => "string",
"double precision" => "number"
}
INTERFACE_TPL = <<~END

10
spec/controllers/api/configs/firmware_configs_controller_spec.rb
View File

@ -13,9 +13,9 @@ describe Api::FirmwareConfigsController do
device.firmware_config.destroy! # Let's test defaults.
get :show, format: :json
expect(response.status).to be(200)
{ encoder_enabled_x: 0,
encoder_enabled_y: 0,
encoder_enabled_z: 0,
{ encoder_enabled_x: 1,
encoder_enabled_y: 1,
encoder_enabled_z: 1,
encoder_invert_x: 0,
encoder_invert_y: 0,
encoder_invert_z: 0,
@ -55,8 +55,8 @@ describe Api::FirmwareConfigsController do
movement_invert_motor_x: 0,
movement_invert_motor_y: 0,
movement_invert_motor_z: 0,
movement_keep_active_x: 0,
movement_keep_active_y: 0,
movement_keep_active_x: 1,
movement_keep_active_y: 1,
movement_keep_active_z: 1,
movement_max_spd_x: 400,
movement_max_spd_y: 400,