Merge pull request #967 from RickCarlino/email_part_ii

Minor Touchups

app/mailers/log_delivery_mailer.rb

@@ -1,5 +1,10 @@
 class LogDeliveryMailer < ApplicationMailer
-  WHOAH = "Device %s is sending too many emails!!! (> 20 / hr)"
+  WHOAH   = "Device %s is sending too many emails!!! (> 20 / hr)"
+  SUBJECT = "🌱 New message from %s!"
+
+  def timestamp(time, zone)
+    time.in_time_zone(zone).strftime("%F %I:%M %p")
+  end
 
   def maybe_crash_if_too_many_logs(device)
     query_params   = { sent_at: 1.hours.ago..Time.now, device_id: device.id }
@@ -9,13 +14,14 @@ class LogDeliveryMailer < ApplicationMailer
   end
 
   def send_a_digest(device, unsent)
+    timezone     = device.timezone || "UTC"
     @emails      = device.users.pluck(:email)
     @messages    = unsent
                     .pluck(:created_at, :message)
-                    .map{|(t,m)| [t.in_time_zone(device.timezone || "UTC"), m] }
+                    .map{|(t,m)| [timestamp(t, timezone), m] }
                     .map{|(x,y)| "[#{x}]: #{y}"}
     @device_name = device.name
-    mail(to: @emails, subject: "🌱 New message from #{@device_name}!")
+    mail(to: @emails, subject: SUBJECT % [@device_name])
     unsent.update_all(sent_at: Time.now)
   end
 

app/views/log_delivery_mailer/log_digest.html.erb

@@ -0,0 +1,13 @@
+<p>
+  <%= @device_name %> sent you an email.
+</p>
+
+<p>
+  Here's what your device had to say:
+</p>
+
+<ul>
+  <% @messages.each do |msg| %>
+    <li><%= msg %></li>
+  <% end %>
+</ul>

app/views/log_delivery_mailer/log_digest.text.erb

@@ -4,4 +4,5 @@ Here's what your device had to say:
 
 <% @messages.each do |msg| %>
  * <%= msg %>
-<% end %>
+
+ <% end %>

webpack/tools/components/toolbay_number_column.tsx

@@ -16,7 +16,7 @@ export function ToolBayNumberCol({ axis, value, dispatch, slot }: NumColProps) {
     <BlurableInput
       value={value.toString()}
       onCommit={(e) => {
-        dispatch(edit(slot, { [axis]: parseInt(e.currentTarget.value, 10) }));
+        dispatch(edit(slot, { [axis]: parseFloat(e.currentTarget.value) }));
       }}
       type="number" />
   </Col>;