spacecruft
/
satnogs-network
1
0
Fork 0
Code Releases Activity

api/serializers: Remove single-use variables (R0914) 

Single-use variables clutter the local namespace and decrease reability.
This patch is part of a series to fix the too-many-locals (R0914)
pylint error for the NewObservationListSerializer.validate method.

Signed-off-by: Fabian P. Schmidt <kerel@mailbox.org>
merge-requests/820/head
Fabian P. Schmidt 2019-12-01 21:53:24 +01:00
parent 77b15b042e
commit 5a0c2c62af
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
network/api/serializers.py
View File

@ -114,7 +114,6 @@ class NewObservationListSerializer(serializers.ListSerializer):
"""SatNOGS Network New Observation API List Serializer"""
def validate(self, attrs):
"""Validates data from a list of new observations"""
user = self.context['request'].user
station_list = []
transmitter_uuid_list = []
transmitter_uuid_station_list = []
@ -141,7 +140,7 @@ class NewObservationListSerializer(serializers.ListSerializer):
station_list = list(set(station_list))
try:
check_schedule_perms_per_station(user, station_list)
check_schedule_perms_per_station(self.context['request'].user, station_list)
except UserNoPermissionError as error:
raise serializers.ValidationError(error, code='forbidden')
@ -168,14 +167,16 @@ class NewObservationListSerializer(serializers.ListSerializer):
"""Creates new observations from a list of new observations validated data"""
new_observations = []
for observation_data in validated_data:
station = observation_data['ground_station']
start = observation_data['start']
end = observation_data['end']
transmitter_uuid = observation_data['transmitter_uuid']
transmitter = self.transmitters[transmitter_uuid]
author = self.context['request'].user
observation = create_new_observation(
station=station, transmitter=transmitter, start=start, end=end, author=author
station=observation_data['ground_station'],
transmitter=transmitter,
start=observation_data['start'],
end=observation_data['end'],
author=self.context['request'].user
)
new_observations.append(observation)