api/serializers: Remove single-use variables (R0914)
Single-use variables clutter the local namespace and decrease reability. This patch is part of a series to fix the too-many-locals (R0914) pylint error for the NewObservationListSerializer.validate method. Signed-off-by: Fabian P. Schmidt <kerel@mailbox.org>merge-requests/820/head
parent
77b15b042e
commit
5a0c2c62af
|
@ -114,7 +114,6 @@ class NewObservationListSerializer(serializers.ListSerializer):
|
||||||
"""SatNOGS Network New Observation API List Serializer"""
|
"""SatNOGS Network New Observation API List Serializer"""
|
||||||
def validate(self, attrs):
|
def validate(self, attrs):
|
||||||
"""Validates data from a list of new observations"""
|
"""Validates data from a list of new observations"""
|
||||||
user = self.context['request'].user
|
|
||||||
station_list = []
|
station_list = []
|
||||||
transmitter_uuid_list = []
|
transmitter_uuid_list = []
|
||||||
transmitter_uuid_station_list = []
|
transmitter_uuid_station_list = []
|
||||||
|
@ -141,7 +140,7 @@ class NewObservationListSerializer(serializers.ListSerializer):
|
||||||
|
|
||||||
station_list = list(set(station_list))
|
station_list = list(set(station_list))
|
||||||
try:
|
try:
|
||||||
check_schedule_perms_per_station(user, station_list)
|
check_schedule_perms_per_station(self.context['request'].user, station_list)
|
||||||
except UserNoPermissionError as error:
|
except UserNoPermissionError as error:
|
||||||
raise serializers.ValidationError(error, code='forbidden')
|
raise serializers.ValidationError(error, code='forbidden')
|
||||||
|
|
||||||
|
@ -168,14 +167,16 @@ class NewObservationListSerializer(serializers.ListSerializer):
|
||||||
"""Creates new observations from a list of new observations validated data"""
|
"""Creates new observations from a list of new observations validated data"""
|
||||||
new_observations = []
|
new_observations = []
|
||||||
for observation_data in validated_data:
|
for observation_data in validated_data:
|
||||||
station = observation_data['ground_station']
|
|
||||||
start = observation_data['start']
|
|
||||||
end = observation_data['end']
|
|
||||||
transmitter_uuid = observation_data['transmitter_uuid']
|
transmitter_uuid = observation_data['transmitter_uuid']
|
||||||
transmitter = self.transmitters[transmitter_uuid]
|
transmitter = self.transmitters[transmitter_uuid]
|
||||||
author = self.context['request'].user
|
|
||||||
observation = create_new_observation(
|
observation = create_new_observation(
|
||||||
station=station, transmitter=transmitter, start=start, end=end, author=author
|
station=observation_data['ground_station'],
|
||||||
|
transmitter=transmitter,
|
||||||
|
start=observation_data['start'],
|
||||||
|
end=observation_data['end'],
|
||||||
|
author=self.context['request'].user
|
||||||
)
|
)
|
||||||
new_observations.append(observation)
|
new_observations.append(observation)
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue