spacecruft
/
satnogs-network
1
0
Fork 0
Code Releases Activity

test_utils: Locally disable redefined-outer-name pylint error (W0621) 

This pylint error is in contradiction with pytest using the argument
name to detect which fixture should be passed to the test method.

Signed-off-by: Fabian P. Schmidt <kerel@mailbox.org>
merge-requests/866/head
Fabian P. Schmidt 2020-01-02 20:33:02 +01:00
parent 1212dd6cfd
commit acb26329c5
2 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.pylintrc3
View File

@ -13,5 +13,4 @@ disable=
R0913, # too-many-arguments
R0914, # too-many-locals
W0201, # attribute-defined-outside-init
W0621, # redefined-outer-name
W0703, # broad-except

22
network/base/test_utils.py
View File

@ -1,4 +1,6 @@
"""Tests for miscellaneous functions for SatNOGS Network"""
# pylint: disable=W0621
from __future__ import absolute_import
import pytest
@ -27,10 +29,12 @@ def observation_without_discussion():
}
def test_community_get_discussion_details_with_discussion():
"""Test getting community discussion when it exists"""
parameters = observation_with_discussion()
details = community_get_discussion_details(**parameters)
def test_community_get_discussion_details_with_discussion(observation_with_discussion):
'''
Test community_get_discussion_details returns details.has_comments=True and the proper urls
for the existing discussion in community (details.slug)
'''
details = community_get_discussion_details(**observation_with_discussion)
assert details == {
'url':
@ -44,10 +48,12 @@ def test_community_get_discussion_details_with_discussion():
}
def test_community_get_discussion_details_without_discussion():
"""Test getting community discussion when it doesn't exists"""
parameters = observation_without_discussion()
details = community_get_discussion_details(**parameters)
def test_community_get_discussion_details_without_discussion(observation_without_discussion):
'''
Test community_get_discussion_details returns details.has_comments=False and the proper urls
for creating a new discussion in community (details.url)
'''
details = community_get_discussion_details(**observation_without_discussion)
assert details == {
'url':