spacecruft
/
satnogs-network
1
0
Fork 0
Code Releases Activity

views/prediction_windows: Refactor parameter parsing into a seperate function (R0912) 

Fixes a too-many-branches (R0912) pylint error.

Signed-off-by: Fabian P. Schmidt <kerel@mailbox.org>
merge-requests/821/head
Fabian P. Schmidt 2019-12-08 20:37:36 +01:00 committed by Alfredos-Panagiotis Damkalis
parent 8df2c36075
commit cfc3f3accb
1 changed files with 22 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
network/base/views.py
View File

@ -349,20 +349,27 @@ def observation_new(request):
)
def prediction_windows_parse_parameters(request):
""" Parse HTTP parameters with defaults"""
return {
'sat_norad_id': request.POST['satellite'],
'transmitter': request.POST['transmitter'],
'start': make_aware(datetime.strptime(request.POST['start'], '%Y-%m-%d %H:%M'), utc),
'end': make_aware(datetime.strptime(request.POST['end'], '%Y-%m-%d %H:%M'), utc),
'station_ids': request.POST.getlist('stations[]', []),
'min_horizon': request.POST.get('min_horizon', None),
'overlapped': int(request.POST.get('overlapped', 0)),
}
@ajax_required
def prediction_windows(request):
"""Calculates and returns passes of satellites over stations"""
# Parse HTTP parameters with defaults
sat_norad_id = request.POST['satellite']
transmitter = request.POST['transmitter']
start = make_aware(datetime.strptime(request.POST['start'], '%Y-%m-%d %H:%M'), utc)
end = make_aware(datetime.strptime(request.POST['end'], '%Y-%m-%d %H:%M'), utc)
station_ids = request.POST.getlist('stations[]', [])
min_horizon = request.POST.get('min_horizon', None)
overlapped = int(request.POST.get('overlapped', 0))
params = prediction_windows_parse_parameters(request)
try:
sat = Satellite.objects.filter(status='alive').get(norad_cat_id=sat_norad_id)
sat = Satellite.objects.filter(status='alive').get(norad_cat_id=params['sat_norad_id'])
except Satellite.DoesNotExist:
data = [{'error': 'You should select a Satellite first.'}]
return JsonResponse(data, safe=False)
@ -374,7 +381,7 @@ def prediction_windows(request):
return JsonResponse(data, safe=False)
try:
transmitter = get_transmitter_by_uuid(transmitter)
transmitter = get_transmitter_by_uuid(params['transmitter'])
if not transmitter:
data = [{'error': 'You should select a valid Transmitter.'}]
return JsonResponse(data, safe=False)
@ -388,10 +395,10 @@ def prediction_windows(request):
Prefetch('observations', queryset=scheduled_obs_queryset, to_attr='scheduled_obs'),
'antenna'
)
if station_ids and station_ids != ['']:
stations = stations.filter(id__in=station_ids)
if params['station_ids'] and params['station_ids'] != ['']:
stations = stations.filter(id__in=params['station_ids'])
if not stations:
if len(station_ids) == 1:
if len(params['station_ids']) == 1:
data = [{'error': 'Station is offline or it doesn\'t exist.'}]
else:
data = [{'error': 'Stations are offline or they don\'t exist.'}]
@ -403,7 +410,8 @@ def prediction_windows(request):
passes_found = defaultdict(list)
for station in available_stations:
station_passes, station_windows = predict_available_observation_windows(
station, min_horizon, overlapped, tle, start, end
station, params['min_horizon'], params['overlapped'], tle, params['start'],
params['end']
)
passes_found[station.id] = station_passes
if station_windows: