Fix firmware logging

config/host/dev.exs

@@ -49,7 +49,7 @@ config :farmbot, Farmbot.System.ConfigStorage,
 config :farmbot, :behaviour,
   authorization: Farmbot.Bootstrap.Authorization,
   system_tasks: Farmbot.Host.SystemTasks,
-  update_handler: Farmbot.Host.UpdateHandler
-  # firmware_handler: Farmbot.Firmware.UartHandler
+  update_handler: Farmbot.Host.UpdateHandler,
+  firmware_handler: Farmbot.Firmware.UartHandler
 
 config :farmbot, :uart_handler, tty: "/dev/ttyACM0"

lib/farmbot/firmware/uart_handler/framing.ex

@@ -115,12 +115,14 @@ defmodule Farmbot.Firmware.UartHandler.Framing do
   end
 
   defp do_parse_code(processed, log_input) do
-    # maybe log input here
     if log_input do
-      Logger.debug 3, log_input
+      Logger.debug 3, processed
     end
+
     parse_code(processed)
   rescue
-    _ -> {nil, :noop}
+    er ->
+      Logger.error 1, "Firmware parser error: #{Exception.message(er)}"
+      {nil, :noop}
   end
 end

lib/farmbot/firmware/uart_handler/uart_handler.ex

@@ -85,8 +85,7 @@ defmodule Farmbot.Firmware.UartHandler do
   def init([]) do
     # If in dev environment, it is expected that this be done at compile time.
     # If in target environment, this should be done by `Farmbot.Firmware.AutoDetector`.
-    tty =
-      Application.get_env(:farmbot, :uart_handler)[:tty] || raise "Please configure uart handler!"
+    tty = Application.get_env(:farmbot, :uart_handler)[:tty] || raise "Please configure uart handler!"
     storage_dispatch = Farmbot.System.ConfigStorage.Dispatcher
     case open_tty(tty) do
       {:ok, nerves} ->