Bug fix: Bad return value move_abs

farmbot_os/lib/farmbot_os/sys_calls/movement.ex

@@ -101,6 +101,7 @@ defmodule FarmbotOS.SysCalls.Movement do
   def handle_movement_error(reason) do
     msg = "Movement failed. #{inspect(reason)}"
     FarmbotCore.Logger.error(1, msg)
+    {:error, msg}
   end
 
   def calibrate(axis) do

farmbot_os/test/farmbot_os/syscalls/movement_test.exs

@@ -80,8 +80,15 @@ defmodule FarmbotOS.SysCalls.MovementTest do
       "kaboom"
     end)
 
-    error_log = Movement.move_absolute(1, 2, 3, 4)
-    assert "Movement failed. \"kaboom\"" == error_log.message
+    msg = "Movement failed. \"kaboom\""
+
+    expect(FarmbotCore.LogExecutor, :execute, 1, fn log ->
+      assert log.message == msg
+    end)
+
+    {:error, error_log} = Movement.move_absolute(1, 2, 3, 4)
+
+    assert msg == error_log
   end
 
   test "move_absolute/4 - error (in tuple)" do
@@ -89,9 +96,15 @@ defmodule FarmbotOS.SysCalls.MovementTest do
       {:error, "boom"}
     end)
 
-    message = "Movement failed. \"boom\""
+    msg = "Movement failed. \"boom\""
 
-    assert message == Movement.move_absolute(1, 2, 3, 4).message
+    expect(FarmbotCore.LogExecutor, :execute, 1, fn log ->
+      assert log.message == msg
+    end)
+
+    {:error, error_log} = Movement.move_absolute(1, 2, 3, 4)
+
+    assert msg == error_log
   end
 
   test "get_position/1 - error" do

farmbot_os/test/farmbot_os/syscalls/point_lookup_test.exs

@@ -39,6 +39,8 @@ defmodule FarmbotOS.SysCalls.PointLookupTest do
 
   test "PointLookup.get_toolslot_for_tool/1" do
     Repo.delete_all(Point)
+    Repo.delete_all(Tool)
+
     t = tool(%{name: "moisture probe"})
 
     important_part = %{