Commit Graph

30 Commits (master)

Author SHA1 Message Date
Adeeb Shihadeh 2c94f15584
linter: don't allow implicitly concatenated strings (#23513)
* linter: don't allow implicitly concatenated strings

* fix hyundai
2022-01-13 14:19:38 -08:00
Adeeb Shihadeh ee52a61c7d
add pre-commit hook for large files (#23505) 2022-01-12 22:52:58 -08:00
Adeeb Shihadeh a1a9a0f342
pre-commit: fix exclude patterns (#23375) 2022-01-03 15:24:34 -08:00
Adeeb Shihadeh a255449539
update pre-commit hook versions (#22526)
* update pre-commit hook versions

* fix mypy
2021-10-14 20:14:00 -07:00
Adeeb Shihadeh 5b641379ae
phonelibs -> third_party (#22477)
* git mv to third_party

* find and replace

* fix release tests

* update pre-commit

* update tici bins

* update eon bins

Co-authored-by: Comma Device <device@comma.ai>
2021-10-07 16:32:44 -07:00
Adeeb Shihadeh 9e03aa0b92
Honda cleanup (#22008)
* cleanup magic numbers

* long tuning

* indentation

* remove noqa

* little more
2021-08-22 00:27:48 -07:00
Adeeb Shihadeh 6e4c2aa4d2
acados support (#21319)
* acados support

* add pyextra to python path

* x86 libs
2021-06-17 16:40:00 -07:00
Adeeb Shihadeh 9fbac812e4 pin pre-commit hook versions 2021-01-30 16:55:07 -08:00
Adeeb Shihadeh 1669e4a5d1
external cleanup (#19647)
* remove external

* put back ffmpeg for now
2021-01-04 14:17:14 -08:00
Willem Melching 5f59fd4f40 fix cppcheck on ubuntu 19.10 2020-07-23 15:24:17 +02:00
Adeeb Shihadeh d204d87b95 enable flake8 F error codes 2020-06-22 14:00:32 -07:00
Adeeb Shihadeh 3c461ca5cc
Add cppcheck as a pre-commit hook (#1646)
* add cppcheck as a pre-commit hook

* fix Dockerfile

* update precommit config

* exclude panda and opendbc
2020-06-19 20:39:34 -07:00
Adeeb Shihadeh c454bff2f8 remove trailing whitespace pre-commi hook for now 2020-06-05 12:52:55 -07:00
Adeeb 367155168a
Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
2020-06-03 16:13:34 -07:00
Willem Melching 2400417084
vehicle model types (#1631) 2020-06-03 13:47:47 -07:00
Adeeb ab83e48ec4
Add pre-commit hooks (#1629) 2020-06-03 12:54:49 -07:00
George Hotz d1d2984f36 fetch image from route script 2020-06-03 11:32:51 -07:00
Willem Melching 843a64c72f
Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh 6466ec982a enable flake8 E502: backslash is redundant between brackets 2020-05-31 17:41:18 -07:00
Adeeb Shihadeh ebed2d1dcc enable flake8 E251: unexpected spaces around keyword / parameter equals 2020-05-31 17:34:47 -07:00
Adeeb Shihadeh f3dcf861c7 enable flake8 E303: too many blank lines 2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Adeeb Shihadeh efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Adeeb 6051061ff8
Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
2020-05-31 00:48:47 -07:00
Adeeb d9bf9f0a40
Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
2020-05-30 20:14:58 -07:00
Willem Melching 266dfe5a9b use github url instead of gitlab mirror 2020-05-28 17:45:32 -07:00
Willem Melching ba2ac1207a
Running pre-commit in CI (#1590)
* Running pre-commit in CI

* fix dockerfile syntax

* dont run on submodule repo folders

* Fix some import errors in ci

* more stuff

* That should be the last one
2020-05-28 15:40:48 -07:00
Willem Melching 3d08dcc3b2
Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
2020-05-28 15:05:04 -07:00
Willem Melching 29aaa44740
flake8 in pre-commit(#1583) 2020-05-27 20:33:05 -07:00
Willem Melching bd06434243
pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
2020-05-27 20:00:14 -07:00