Commit Graph

81 Commits (master)

Author SHA1 Message Date
Adeeb Shihadeh 2219cb4478
cars: cleanup CS usage (#23957) 2022-03-18 15:39:22 -07:00
Shane Smiskol 31a6b141d6
Docs: auto-generate supported cars documentation (#23762)
* make CAR class enum, and values.py formatting

* Revert "make CAR class enum, and values.py formatting"

This reverts commit 04d9817e9d.

* stash

* add supported packages and model years

* don't change model years in fps

* move Lexus to info dict and make int enum

* remove sometimes wrong model years from name string

* use enum names

* convert Honda's values

* nice names

* use name

* GM

* Mazda, Ford

* Hyundai: WIP

* finish Hyundai

* fix

* Nissan

* Subaru

* Tesla

* formatting is for another PR

* Chrysler: todo: unify the Pacificas?

* do volkswagen

* this isn't a zoo

* skip enums for now

* Update selfdrive/car/volkswagen/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

* set All

* temp cars

* auto-generate CARS.md

* update type hinting

* add generated file

* add longitudinal star to cars that support disabling radar

* add TODO

* add notes

* add min_steer_speed exception for hatchback

* add minimum steering speeds

* Add exceptions and run generator

* Missing Telluride

* fix Prius v

* missing Prius Prime

generate

* start to convert years to strings

* Fixup Hyundai

* convert year sets to strings

* handle this

* missing S3

* Fix and add all missing cars (verified with script

* Supported Package fixes

* add get_tiered_cars

* Check radarOffCan for removing most Honda from op long

* Update for Avalon stop and go update on master

* Fix missing car params

* add my temporary script i'm using to verify new generated DBC

add my temporary script i'm using to verify new generated DBC

* generate with jinja template

* add header and footer

* clean up

* rename

rename

* add exceptions. jinja is nice, but why are its loop indexes starting at 1?

* add list of known car videos

* See how these look

* Add nice table formatting for column description

Add nice table formatting for column description

* generate

* consisten br tag

* small clean up

* temp

* Move car videos into CarInfo

* add new copy and rename to footnotes

* Revert "temp"

This reverts commit 93c3fce1d3.

clean up

* generate

* replace with svg

* simplify a bit

* add footnotes to CarInfo

* move some variables to docs.py

* Add video link for Acadia

* Make Footnote an enum so we don't use random ints

* static analysis fixes

* move to CARS.md

* fix last missing footnote

* add to release files

* rm test file

* use svg

generate

* fix sorting

* not needed

* not sure how this got here

* remove Sedan/Couple and add Diesel footnote

* finish todos

* move make specific footnotes to selfdrive/car/*/values.py

rename

* change to zeros

* align bottom to center

* Apply some suggestions

* Update selfdrive/car/mock/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update copy

* Try headers + bullet points

* somehow better

somehow better

* finish updating copy

* move template and add links to sups

* stars shouldn't be clickable

that didn't work

try this

try this

this is better

* add type hints to CarInfo

add more type hinting

* optional needs a type and any covers all (?)

* move good steering torque to */values.py

* dataclasses are much nicer than attr

* use tuple

* Update docs/cars.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* suggestions

* suggestions

* suggestions

remove

* clean up a bit

* add more type hints

* center stars and remove hardcoding from template

* update copy

* Add test

* Fix types

Fix types

* add supported cars documentation test

* clean up

* replace with docs_definitions

* Add back Footnote enums

* Ah so these are like fstrings!

* Update selfdrive/car/CARS_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update year from master merge

* Fix longitudinal star from merge

* sort properly stars by Column enum

* clean up

* HKG: Sorry guys

* Prius V gets FSR star, like others

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update comment

* No Prius docs change for now

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-16 21:27:05 -07:00
Adeeb Shihadeh bae78dd46b
don't read params in car interfaces (#23978) 2022-03-16 15:17:47 -07:00
Adeeb Shihadeh 5c3f3e44bc
break up selfdrive.config (#23959)
* break up selfdrive.config

* add to release files

* fix import order
2022-03-13 21:42:39 -07:00
Adeeb Shihadeh 87849f93b1
better steer fault names (#23890)
* better steer fault names

* bump cereal
2022-03-01 22:53:55 -08:00
Adeeb Shihadeh 3c83975ef6 resolve misc car TODOs 2022-02-06 13:50:59 -08:00
Shane Smiskol 95caa5f399
CANParser: consistent style for adding signals/checks (#23646)
* consistent style, like toyota

* typo
2022-01-28 13:20:13 -08:00
Shane Smiskol 3645186d7c
CANParser: remove default values (#23642)
* draft

* remove rest

* bump

* update radar interfaces

* do rest and formatting

* bump

* fix mising check

* try this

* Revert "try this"

This reverts commit 0d26d9a072.

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-01-27 17:06:18 -08:00
Jason Young 57156c4482
Chrysler: remove standstill exception for gas disengage (#23515)
* Chrysler: remove standstill exception for gas disengage

* remove test exception

* bump panda

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-01-13 16:06:56 -08:00
Adeeb Shihadeh 2c94f15584
linter: don't allow implicitly concatenated strings (#23513)
* linter: don't allow implicitly concatenated strings

* fix hyundai
2022-01-13 14:19:38 -08:00
Dean Lee a653461dec
check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2022-01-10 16:36:51 +01:00
Willem Melching 4f1eb4278a
Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
2021-12-16 13:08:20 +01:00
Willem Melching e6180738fd
add CarParams.wheelSpeedFactor (#23079)
* add CarParams.wheelSpeedFactor

* Fudge speed for Lexus RX

* should have been the TSS2 model

* bump cereal

* refactor into function

* update refs
2021-12-03 14:57:53 +01:00
Robbe Derks 91987f38d4
Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
2021-10-08 17:54:34 +02:00
Adeeb Shihadeh 649af76fd4
remove community supported cars from community features (#22330)
* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
2021-09-23 17:34:52 -07:00
Adam Boeglin b5daca3881
Added fingerprint for 2018 Jeep Trackhawk (#21976)
* Added fingerprint for 2018 Jeep Trackhawk

When connecting the Comma3 to my Trackhawk with the latest jvePilot beta, it showed the error "Car Unrecognized: Dashcam Mode".

Obtaining this fingerprint resolved the issue. I don't know if it works with any other model years.

* merge fingerprints

* add missing vals

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-02 15:12:43 -07:00
HaraldSchafer 1ac89f14aa
Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh c72d163e14
deprecate CP.enableCamera (#21509)
* deprecate CP.enableCamera

* more removal

* one more

* update refs
2021-07-07 14:59:18 -07:00
Erich Moraga 66035ccac9
Add PACIFICA_2020 fingerprint (#21106) 2021-06-18 15:52:58 -07:00
CrispinFlowerday 7458e143e3
Subaru: show LDW on dash for correct lane (#20934)
* Emit correct alerts for LDW Left & Right on Subarus

This change switches the ldw event to use VisualAlert.ldw and
alters all cars to use the prior behaviour for that alert, except
global subarus - they emit the correct warning to the dash

* Remove whitespace, and add comment about not overwriting stock alerts

Co-authored-by: Crispin Flowerday <crispin@theflowerdays.com>
2021-06-07 15:06:28 -07:00
Jason Young 83ca5a0d29
Cleanup carstate quoting styles (#21109)
* carstate quoting style: VW

* carstate quoting style: Chrysler

* carstate quoting style: Ford

* carstate quoting style: GM

* carstate quoting style: Honda

* carstate quoting style: Hyundai

* carstate quoting style: Mazda

* carstate quoting style: Nissan

* carstate quoting style: Subaru

* carstate quoting style: Soulless Appliances

* Sorry Honda!
2021-06-02 15:51:54 +02:00
Adeeb Shihadeh c736b7e5bb chrysler pacifica 2020 fingerprint values 2021-05-25 14:23:05 -07:00
TheWizard1328 ed0c8a770f
Chrysler Pacifica Fingerprint (#20935)
* Update values.py

* Update values.py

* Update selfdrive/car/chrysler/values.py

* Update values.py

Chrysler Pacifica 2020 fingerprint values added.

* Update values.py

* Update values.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-05-19 20:02:08 -07:00
ShaneSmiskol 551091bcfa
Deprecate brakeLights field (#20954)
* remove all references to CS.brakeLights

* unused red

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-05-18 17:48:02 -07:00
xps-genesis 1e473d764a
Chrysler BSM info signal (#20694)
* Chrysler BSM info signal

* change to ==1

* add checks to enable bsm

* add fingerprint can id for enableBsm

* gate behind enableBsm

* fix indenatation

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-05-04 20:37:39 -07:00
mahlzeit1948 f6d800a89e
Fix Chrysler Pacifica weight (#20647)
* Update interface.py

2858 is the gross vehicle weight of the hybrid (maximum weight of vehicle + cargo).
Curb weight for the ICE is 1964 kg, for the hybrid it is 2242 kg

* hybrid & update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-04-11 17:18:31 -07:00
vanillagorillaa 4a5e43cdcc
2021 Pacifica Hybrid values (#20380)
* 2021 Pacifica Hybrid values

* combine all 2019 PacHy fingerprints into one

* Revert "combine all 2019 PacHy fingerprints into one"

This reverts commit a08ede1666.

* this one isn't needed, fully contained in one below with the new values
2021-03-31 00:57:48 -07:00
qadmus 0d61d8a4b6
int(round()) on apply_steer for correct comparison after rate limiting (#20425) 2021-03-22 13:01:33 +01:00
Drew Hintz 01f20229cb
include PACIFICA_2020 in late-model behavior (#20399)
These models need to turn off gone_fast_yet bit at -3 to avoid LKAS
faults.

This was likely an accidental omission from PR #1297
To avoid future similar mistakes, we could define a list of these cars
in values.py instead of having the list in multiple places.
2021-03-18 17:29:36 -07:00
vanillagorillaa d1b651af7d
2021 pacifica hybrid - additional fingerprint values (#20164)
* 2021 Pacifica Hybrid

* this weird space always gets added

* one more space
2021-02-25 22:20:23 -08:00
Shane Smiskol 700f7db644
Chrysler: Default fingerprint argument to empty fingerprint (#20146) 2021-02-24 15:41:20 +01:00
Adeeb Shihadeh 312b681a46
cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65eb.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
2021-02-16 21:39:32 -08:00
vanillagorillaa 4e99b4c232
Chrysler Pacifica: additional 2020 Fingerprint values (#20032)
* Additional 2020 Values

* space
2021-02-07 17:36:34 -08:00
Chris McCammon 332e01ee91
2021 Pacifica Hybrid fingerprint (#19846)
* Merge fingerprint of 2021 Pacifica Hybrid from b66bf349eecf2fda

* add route information

* remove comment
2021-01-20 13:48:48 -08:00
vanillagorillaa f005fd0796
Pacifica Fingerprint Addition (#19750)
* Pacifica: Should fix dashcam mode when remote start

* extra indent
2021-01-15 13:40:23 -08:00
vanillagorillaa 937aa829a3
Chrysler non-ACC Fix - Only allow openpilot in ACC mode (#19581)
* initial try, needs to be tested

* Chrysler: Add to CAN parser

* Chrysler: move cruise state by other dash message

* fix messed up force push

* whitespace

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-01-06 12:06:03 -08:00
Willem Melching e4cf43c6fc
Move all CarControllerParams into values.py (#19663)
* toyota

* use scale from values.py

* nissan

* subaru

* honda

* gm

* toyota combine into CarControllerParams

* nissan refactor

* chrysler refactor

* mazda refactor

* hyundai refactor

* subaru refactor
2021-01-06 11:20:44 +01:00
Adeeb Shihadeh 47c21f10f5
grey panda is unsupported (#2458) 2020-11-03 19:56:25 -08:00
Adeeb Shihadeh 1e44b99478
Add missing chrysler can parser checks (#1967)
* add missing chrysler can parser checks

* toyota

* toyota cam

* toyota freqs

* chrysler freqs

* doors

* just chrysler for now

* update refs

* update again
2020-08-02 18:11:42 -07:00
Adeeb Shihadeh 892e1162c0
Car cleanup (#1924)
* cleanup car code

* more pruning

* little more

* less pylint disables

* radar stuff

* fix

* udpate refs

* fix honda bosch

* fix test
2020-07-25 15:07:27 -07:00
Adeeb Shihadeh 35a5b057c1 minor cleanups from LGTM 2020-07-17 23:34:38 -07:00
Adeeb Shihadeh 1ef3b20955 2020 Jeep Grand Cherokee fingerprint
Squashed commit of the following:

commit a1a14048375b4d9c9181b2797621e999738104f8
Author: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Date:   Mon Jul 13 16:30:54 2020 -0700

    cleanup

commit cf7d4bb162c5018a05b81dd83f124b3ef7826714
Author: Tunder (Chris in RL) <34691234+Tundergit@users.noreply.github.com>
Date:   Sun Jul 12 21:08:59 2020 -0700

    added missed value

commit b91af6eef1b5d966cf4342475a37129ddb46e8de
Author: Tunder (Chris in RL) <34691234+Tundergit@users.noreply.github.com>
Date:   Sun Jul 12 20:52:41 2020 -0700

    Update values.py

commit d3d564fc76db19eae1464d6d938fdc43aa9b6d4e
Author: Tunder (Chris in RL) <34691234+Tundergit@users.noreply.github.com>
Date:   Fri Jul 10 00:23:35 2020 -0700

    add support for 2020 Grand Cherokee
2020-07-13 17:00:27 -07:00
VirtuallyChris 59cbaf88ef Add missing fp value for Jeep Grand Cherokee 2019 2020-06-24 16:11:59 -07:00
Adeeb 367155168a
Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
2020-06-03 16:13:34 -07:00
Willem Melching 843a64c72f
Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh 6466ec982a enable flake8 E502: backslash is redundant between brackets 2020-05-31 17:41:18 -07:00
Adeeb Shihadeh f3dcf861c7 enable flake8 E303: too many blank lines 2020-05-31 17:21:11 -07:00
Adeeb Shihadeh 27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Adeeb Shihadeh efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Adeeb 6051061ff8
Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
2020-05-31 00:48:47 -07:00