Commit Graph

59 Commits (3d08dcc3b27936cb14c0eae63605be9a6c077380)

Author SHA1 Message Date
Willem Melching 3d08dcc3b2
Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
2020-05-28 15:05:04 -07:00
Willem Melching 29aaa44740
flake8 in pre-commit(#1583) 2020-05-27 20:33:05 -07:00
Willem Melching bd06434243
pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
2020-05-27 20:00:14 -07:00
Adeeb Shihadeh a1ffcdd253 update refs after radarState fields populated 2020-05-26 18:12:12 -07:00
Willem Melching fcf879d783
Add permanent CAN error alert (#1549)
* Add permanent CAN error alert

* canValid needs some time to initialize

* update ref
2020-05-21 16:08:05 -07:00
Willem Melching d099e09fb7
Handle posenet and sensor alerts in locationd (#1541)
* handle posenet and senor alerts in locationd

* defaults now set in capnp file

* Cleanup c++ version of params learner

* update ref commit
2020-05-19 16:45:20 -07:00
Adeeb d976233f69
Alerts + Events refactor (#1466) 2020-05-14 15:21:21 -07:00
Willem Melching 27ffa29f6c
Fix counter in HKG clu11 message (#1484)
* fix counter in clu11 message

* update ref
2020-05-10 20:13:35 -07:00
Willem Melching 5182da3100 fix update ref script 2020-05-10 18:55:53 -07:00
Adeeb 337529d5cb
Add steerWarning and steerError to carState (#1444)
* Add steerWarning and steerError to carState

* fix gm and hyundai

* update refs
2020-05-01 13:13:12 -07:00
Willem Melching 71589fc92e Logreader can take car of downloading the files 2020-04-30 15:09:19 -07:00
Chris Souers 0f530be2b4
Static 0xe5 on Honda Bosch (#1420)
* Recreate a static 0xe5 and send to radar

* remove unneeded declaration

* Update ref_commit
2020-04-28 14:12:46 -07:00
Willem Melching 94bba46d6d
Hyundai: use same gas pressed bit as in panda (#1428)
* use same bit as in panda

* remove lines

* update ref

* switch gas pedal signal
2020-04-27 15:28:34 -07:00
Willem Melching f7f0a81d13
Remove fake yaw rate from carstate (#1426)
* remove fake yaw rate from carstate

* update ref
2020-04-27 14:10:07 -07:00
ZwX1616 922055f464
orange distracted alert is now continuous (#1412) 2020-04-23 14:15:05 -07:00
Willem Melching c9cefb2fbc nissan and hyundai are community 2020-04-17 11:42:33 -07:00
Willem Melching 7d78cef34b
Hyundai-Kia-Genesis (HKG) (#1362)
* hkg

* Cleanup

* Update readme

* more fixes and cleanup

* Old genesis

* Typoe

* Test car models

* Update comment

* Fix brake pressed

* Update release notes

* Fix vEgo

* Add sonata

* Add sonata values

* Temporarily remove doors check. It doesn't work

* Sonata uses crc8

* Fix tests

* Changes for LFA

* Add comment

* Does this improve the hud?

* Proper signal name

* Force the right value

* some ui stuff

* more comments

* Show lane lines on sonata

* cleanup dash

* fix last ui issues

* Fix doors

* update CI

Co-authored-by: Comma Device <device@comma.ai>
2020-04-15 19:33:24 -07:00
ZwX1616 133b1a20b4
RHD support for driver monitoring (#1299) 2020-04-15 16:48:44 -07:00
HaraldSchafer a18832748c
rely on carstate to be sure (#1363)
* rely on carstate to be sure

* relies on carstate now too

* don't know how else to make this work

* update ref

* clean up hacks

* prev ref was weirdly bad?

* lets try that from my machine

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-04-15 13:14:23 -07:00
Adeeb 928b1561aa
Toyota: use universal gas pressed bit to match panda safety (#1335)
* Toyota: use universal gas pressed bit to match panda safety

* update ref
2020-04-09 12:09:20 -07:00
Willem Melching 3eda14f2fe update test ref 2020-04-07 21:43:57 -07:00
Adeeb 0f6c22ce8b
Unit test for alert width (#1307)
* unit test for alert width

* fix scale

* comment

* fix offending alert text

* rename

* update process replay refs

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-04-07 21:37:17 -07:00
martinl d0b3c69505
Add Subaru gearShifter to carstate (#1318)
* Add Subaru gearShifter to carstate

* reset submodules, remove ignore gearshifter from subaru interface

* update apks to master

* update ref_commit
2020-04-07 11:55:17 -07:00
Arne Schwarck 43b62d8bb6
Toyota Tss2 Blindspot signals (#1309)
* Toyota Tss2 Blindspot signals

Adding these signals are easy, they are on the can bus.

* Update ref_commit
2020-04-03 08:31:12 -07:00
Andre Volmensky 9c16ad8e18
Nissan set speed (#1289)
* LKA_ACTIVE should be set with enabled, not cruiseState.enabled. Was causing panda violations

* Added cruiseState.speed to Nissan X-Trail

* Bump opendbc

* Remove redundant if statement

* Fix tests

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-03-29 15:28:06 -07:00
Willem Melching 46ae7f0369 update ref 2020-03-29 14:53:51 -07:00
Willem Melching fca82ba503 add nissan to test_processes 2020-03-27 21:54:40 -07:00
George Hotz 2ecddbb3b6
Move all non Honda+Toyota to community supported (#1280)
* readme update, still need the gates on the cars themselves

* add community feature gating to other car ports

* promotion note

* from the brand

* readme touchups

* sell the harness

* full ISO

* update ref

Co-authored-by: George Hotz <geohot@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-03-27 10:59:07 -07:00
HaraldSchafer 5f8e3b4d93
New lane planner (#1276)
* better lane planner

* works well on test

* needs speed now

* update ref
2020-03-25 16:57:58 -07:00
Willem Melching e074b4fbe8 fix test ref 2020-03-23 14:16:32 -07:00
HaraldSchafer 628e7e6968
stricter calibration requirements (#1227)
* stricter requirements

* update refg

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-03-13 11:15:58 -07:00
rbiasini fe911bcca8
abstract pedalPressed event (#1218)
* abstract pedalPressed event

* Fix bug

* update refs
2020-03-08 23:35:00 -07:00
rbiasini 24e092ffab
Subaru brake check (#1212) 2020-03-06 23:17:16 -08:00
Jason Young c2200baf60
Updates to Volkswagen port (#1147)
* Remove unreachable Radar Fault alert code
* Update max torque
2020-03-05 22:45:28 -08:00
Shane Smiskol 6ff881f789
initialize all messages in 1 line (#1206) 2020-03-05 17:32:52 -08:00
Willem Melching 6db044c86c
Nissan port - dashcam only (#1203)
* Nissan port

* add x-trail to release notes

* update readme and model

* remove from releases until tested

* Don't test Nissan for now

* Forced dashcam in test_car_models
2020-03-05 15:40:07 -08:00
Willem Melching 78c1745ed5 add progress to save_logs 2020-03-05 13:24:21 -08:00
Harald Schafer c0557b0519 reupdate calib 2020-03-04 19:02:14 -08:00
HaraldSchafer 63d3bb517f
Pulse desire (#1172)
* initial

* compilation fixes

* add desire

* pulse desire

* 0d5728f6-a918-40a6-bce3-a9d0f1238180/20

* cleaner

* inject model

* inject model

* test runs

* ah already done I see

* remove useless

* update

* updates, doesnt work

* fix generating new references

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-03-04 18:51:45 -08:00
Harald Schafer bae7816999 stable calib 2020-03-04 18:44:33 -08:00
rbiasini e90d0e832d
Add brake press disengagement in Chrysler (#1163)
* Add brake press disengagement in Chrysler
2020-02-27 10:14:21 -08:00
Willem Melching 61706ce3a0 fix update refs 2020-02-26 16:44:53 -08:00
Adeeb 796d5c8cca
Process replay enhancements (#1153)
* process replay: exclude processes and cars
2020-02-26 11:31:27 -08:00
rbiasini a817d1c1e7
Hyundai: fix gas and gasPressed signals (#1152)
* Hyundai: fix gas and gasPressed signals

* upd panda

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-02-22 20:46:27 -08:00
rbiasini 9685a5a743
Abstract gasPressed for all cars (#1151)
* min_steer_speed alert (with adjusted hysteresis) for all cars, abstracted gas pre_enable event

* move lines a bit

* more GM cleanup

* typo

* move espDisabled to carState packet

* brought back min steer speed alert only in hyundai. It's a bit tricky and behavior should be changed

* ops, wrong change

* bug

* update cereal

* update ref
2020-02-21 18:24:37 -08:00
Adeeb e8cb6ea06a
Abstract common events + event cleanup (#1129)
* too many if

* unused

* whitespace

* key

* sefldrive/car/*

* no more gctx

* lower

* start abstracting common events

* all cars

* start small

* all cars

* reverse gear

* wrongCarMode

* wrongGear

* espDisabled

* steerUnvailable

* make linter happy

* c isn't used

* fix esp_disabled in VW

* update ref

* more red

* more cleanup

* fix subaru

* update ref
2020-02-20 16:22:25 -08:00
rbiasini af39d74a5b
Abstract std params (#1138)
* get_can_parser and get_cam_can_parser are now standard static methods
2020-02-20 14:06:02 -08:00
Willem Melching 5bf81617bd Add VW to process replay test 2020-02-20 11:46:57 -08:00
Greg Hogan 57c44e3705
WIP: Honda Steering Improvements (#983)
* move honda steer params to CarParams

* use breakpoints/values from firmware

* remove comment

* civic fw mod max included deadzone

* civic bosch needs to be separate

* script to measure steering accuracy

* civic tuning

* update cr-v values

* cleanup

* averaging over 10 samples was silly

* update stock civic and cr-v tuning

* remove comment

* update replay expected results
2020-02-19 13:28:01 -08:00
rbiasini 0c67143c92
Carstate returns capnp struct (#1115)
* Before abstraction, adding speed init from VW as well

* strting to abstract carstate class

* fix bug and update lock?

* revert pipfile change

* another bug

* fix linter

* bug fix

* remove a bunch of diplicated kf code

* better to not have class vars. will abstract __init__ anyway later

* abstract common instance vars in carstate init and a generic gear parser static method

* abstract gear parser for chrysler

* abstract gm gear parser too

* remove unnecessary random vars

* Chrysler: carstate returns capnp struct directly

* revert ref commit

* test ref

* WIP

* more WIP

* ops, missed this conflict

* ford as well

* not sure why this got deleted

* no need to copy

* remove copy

* remove copy import

* remove unnecessary intermediate variable

* remove obsolete comments

* GM: have carstate returning capnp struct directly

* Honda carstate also outputing capnp struct

* hyundai too now returns capnp from carstate

* ops, not meant this

* Subaru carstate also returning capnp

* Toyota: capnp struct as output of carstate

* fix bool

* minor simplififcation in Honda

* no need to negate

* VW carstate returning capnp struct (#1118)

* VW carstate also returning capnp struct

* fixed typo

* Remove unused blinker button (#1119)

* remove unused blinker button

* ops, this wasn't meant

* remove blinker button for VW as well

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-02-18 15:28:15 -08:00