Commit Graph

52 Commits (7d9fdd1108ae1c8136a527d1369d25bb890783fb)

Author SHA1 Message Date
Adeeb Shihadeh 7d9fdd1108
Toyota: whitelist LTA message (#638)
* Toyota: whitelist LTA message

* LTA safety

* simple test

* little more test

* misra
2021-04-06 16:56:03 -07:00
Willem Melching e0a706e4f0
Stricter pylint (#550)
* stricter pylint

* Add as argument
2020-06-02 16:27:07 -07:00
Adeeb d7f7b14118
Enable almost all Flake8 checks (#548)
* fix W391

* E262

* E703

* W293

* some E

* E231

* some more E

* E225

* more E

* E252

* no tabs

* more tabs

* E701

* uds.py

* almost all of them

* only e265 left

* not sure why this is triggering on commented out code

* ignore esptool
2020-06-01 01:49:26 -07:00
Adeeb Shihadeh eba113cb67 backslash is redundant between brackets 2020-05-31 17:39:42 -07:00
Adeeb Shihadeh 9102c16118 two spaces before inline comment 2020-05-31 14:07:01 -07:00
Adeeb Shihadeh ba6355d4c0 unused lines 2020-04-30 14:53:43 -07:00
Adeeb 9874e73350
Abstract steering safety tests for Toyota and Chrysler (#520)
* start abstracting torque steering tests

* remove duplicate

* chrysler

* remove that

* revert that for now

* fix toyota

* unused
2020-04-29 20:37:12 -07:00
Adeeb 0bc864b3d5
Make torque-based steering state global (#518)
* use generic steering state vars for toyota

* chrysler

* gm

* comment

* more unnecessary lines

* hyundai

* subaru

* vw

* fix mazda
2020-04-28 10:33:20 -07:00
Adeeb e5a586eea9
Abstract gas interceptor tests (#517)
* abstract interceptor tests

* honda
2020-04-27 20:35:36 -07:00
Adeeb Shihadeh 0632710acd base class for different panda safety tests 2020-04-27 15:39:08 -07:00
robbederks 0336f625dc
Pedal gas pressed safety limits (#507)
* Fixed toyota pedal gas disengage and increased pedal limits to OP limits +5%

* Fix safety unit tests?

* Fix imports

* Fix imports #2
2020-04-16 14:52:59 -07:00
Adeeb 6c442b4c33
Safety Test Refactor: Volkswagen MQB (#493)
* pull test_volkswagen_mqb.py from safety-test-refactor

* prev_brake is now a standard test

* abstract cruise enable/disable tests

* unused

* move

* hack to get around unittest reporting skipped tests
2020-04-13 17:13:08 -07:00
Adeeb abce8f32b1
Safety Test Refactor: Toyota + support code (#491)
* bring over toyota + support code from safety-test-refactor

* old tests still use StdTest

* don't duplicate

* test fwd

* make linter happy

* fix indent

* fix ident

* fix order

* whitespace

* move some common tests

* cleanup

* unused

* comment
2020-04-10 13:45:55 -07:00
Adeeb bc90b60f97
toyota: use universal gas pressed bit (#488)
* toyota: use universal gas pressed bit

* fix tests
2020-04-09 12:09:34 -07:00
eFini 4e98bbe8c9
Apply unsafe allow gas mode to all cars. (#480)
Apply unsafe iso accel/decel limit to toyota.
2020-04-06 08:56:36 -07:00
rbiasini 0696730c14
Toyota: add missing offset from speed signal (#469)
* Toyota: add missing offset from speed signal

* Let's also define ABS value in macro
2020-03-11 17:30:30 -07:00
rbiasini 0f21b19bb3
Cleanup pedal nomenclature (#467)
* consolidate gas and brake nomenclature

* fixes in code and tests
2020-03-08 23:48:00 -07:00
rbiasini ceff91d3c5
Standardize brake safety tests (#465)
* WIP: improve safety test format

* Fix tests
2020-03-07 23:22:47 -08:00
rbiasini 4368748851
WIP: Toyota brake check. (#459)
* Toyota brake check with safety tests
2020-03-05 00:16:03 -08:00
Arne Schwarck eb5020b7a9
Add the ability to communicate with BSM (#433)
* Add the ability to communicate with BSM

To poll the blind spot sensor 0x750 is required

* Add blindspot monitor communication
2020-02-11 10:15:39 -08:00
rbiasini d301a59d64
WIP: Checksum checks (#403)
* add lag message check for all supported cars
* add checksum and counter checks for toyota and honda
* add rx hook regression tests
2019-12-21 10:25:54 +01:00
Riccardo 110ca03160 remove long_controls_allowed unused param and reduce technical debt 2019-12-20 16:17:37 -08:00
Riccardo 4f9c879696 remove abunch of lines from safety regression tests by using common make_msg function 2019-11-19 11:29:04 -08:00
Riccardo d5c772b0b1 Fixe Toyota message white-list 2019-11-18 12:52:31 -08:00
rbiasini 6249a183d6
tx_hook shall have a white-list of messages (#381)
* Started whitelisting messages

* Also toyota and cadilalc fix

* bug fixes and better checks. Need to figure out a solution for honda

* Whitelist also for subaru

* Added Chrysler as well to whitelist

* And Hyundai too

* now all supported cars should have a whitelist of messages

* Fix linter

* This should fix process replay

* Honda too is now whitelisted

* struct typedef

* Had forgot GM

* had a wrong addr for GM whitelist

* This should fix all the tests

* bump panda
2019-11-17 00:24:19 -08:00
Riccardo e74ed93640 safety tests a bit more simplified 2019-11-15 01:12:54 -08:00
Riccardo 2027765bd0 relay malfunction test centralized 2019-11-15 01:03:34 -08:00
Riccardo 8af1a01ac6 clean up safety tests 2019-11-15 00:52:34 -08:00
rbiasini cfcce8f06b
WIP: Relay malfunction (#384)
* relay malfunction handling. WIP

* more cars to relay_malfunctions

* fixed safety tests

* minor change

* Fix linter

* all cars now have a relay_malfunction safety check

* added relay_malfunction safety test for fwd hooks

* added proper regression tests for relay malfunction to all cars

* temp patch to not fail regression in honda bosch

* also addr 0x194 is some nidec honda is steer control

* proper relay check for honda bosch too
2019-11-15 00:32:45 -08:00
Riccardo e8d7ed1d90 Rename function name to not confuse safety_set_mode and set_safety_mode 2019-11-06 14:30:22 -08:00
rbiasini fce38a91d7
Linter python (#299)
* Added pyflakes and Pylint for python

* Actually run linter in CI

* some simple pyflakes changes

* Add flake8 to panda reqs for linter test

* flake8 errors are fixed

* run flake8 in regression tests

* meant to run flake8

* hack to ignore unused import

* bug

* fix bugs in tucan_loopback

* Another fix by using set_safety_mode

* added pylintrc file

* more fixes and enabled pylint as well

* Fix pylint in circleci

* added linter to readme
2019-10-15 14:03:31 -07:00
rbiasini 70219d7bb2
match safety enum in cereal (#285)
* match safety enum in cereal

* removing tons of hardcoding

* add pythonpath to safety test

* Fix safety test in Docker
2019-10-02 18:20:32 -07:00
Riccardo 0de9ef73cc Revert "Final 2to3 on the whole repo"
This reverts commit c92fd3bc90.
2019-09-25 17:01:13 -07:00
Riccardo c92fd3bc90 Final 2to3 on the whole repo 2019-09-25 16:58:56 -07:00
Riccardo 2dc34096a0 2to3 applied 2019-09-24 22:33:46 -07:00
Riccardo 1e2412a297 env python -> env python3 2019-09-24 17:50:53 -07:00
rbiasini e49d0dbbd6
Pedal: use avg between tracks (#253) 2019-07-15 13:15:22 -07:00
Riccardo da59e0cb9a Fix toyota tests 2019-06-20 18:41:41 -07:00
rbiasini 57a6c493bb
Toyota gas pressed: reconcile panda code with openpilot (#212) 2019-06-12 17:51:47 -07:00
Riccardo 133269a1a4 Added fwd test coverage for Toyota, Hyundai and Chrysler too. Removed replay tools for Chrysler, as a generic replay tool has been recently added 2019-06-11 19:24:08 -07:00
quillford cd20d123c4 refactor tests/safety to use generic hooks (#208)
* refactor tests/safety to use generic hooks

* cleanup refactor

* removed dead code
2019-06-11 01:31:00 -07:00
Riccardo 71099efaba AddedToyota safety test around long_controls_allowed logic and fixed a bug 2019-06-05 15:29:09 -07:00
rbiasini 09714e3a44
Toyota gas cancellation (#200)
* cancel on pedal press for toyota.
2019-06-05 13:38:59 -07:00
Riccardo 95b010943f Toyota: fixed regression safety tests 2019-06-03 16:53:03 -07:00
Riccardo Biasini 4f73cb48b8 Toyota pedal: checking for no pedal being commanded when openpilot is off 2019-03-02 15:22:09 -08:00
Riccardo 8291971d9a Toyota: using a more generalized CRUISE_ACTIVE bit that works on all cars 2018-11-04 13:57:25 -08:00
Riccardo ba8762d5a3 Toyota safety: vars and consts need 'toyota_' prefix 2018-07-17 19:43:06 -07:00
Commaremote bf70f51596 Safety: increase buffer for sampled signals. TBD a violation feedback from board to prevent car faults 2018-06-03 17:39:57 -07:00
George Hotz e7a2b3a209 add ipas tests 2018-04-11 14:42:56 -07:00
Riccardo 02c1ddf5fc Revert "added steer override check when IPAS is in control (#106)"
This reverts commit 7d21acbccc.
2018-04-11 14:00:25 -07:00