Commit Graph

1336 Commits (jebba)

Author SHA1 Message Date
Rick Carlino 0224ce6d65 Move to group of points (API-only) 2019-01-08 10:19:52 -06:00
Rick Carlino f2704db2d8 Merge branch 'staging' of github.com:FarmBot/Farmbot-Web-App into friday 2019-01-08 09:29:07 -06:00
Rick Carlino 4248c8fe4a Resolve conflicts in strucutre.sql 2019-01-07 15:04:42 -06:00
Rick Carlino 2e94fc61bc Get coverage back to 💯% 2019-01-04 08:18:02 -06:00
Rick Carlino f57ac121c3 Minor changes (fixes `tag` related 500) 2019-01-03 16:48:57 -06:00
Rick Carlino 5e46edc1fb Migrate away from DeviceSerialNumber table CC: @connorrigby 2019-01-03 15:49:40 -06:00
Rick Carlino e0efa1ee27 return rather than raise 2019-01-03 11:41:52 -06:00
Rick Carlino 1b309ddf15 Add application-layer uniqueness validation (No DB-level constraint yet) 2019-01-03 09:54:48 -06:00
Rick Carlino 059277ae85 WIP: Upgrade bundler deps. 2019-01-02 10:35:08 -06:00
gabrielburnworth 0d9ac0628f use default placeholder image 2018-12-30 10:04:24 -08:00
Rick Carlino f1e1858623 Use eq() instead of be() in specs 2018-12-21 15:11:47 -06:00
Rick Carlino 80587c2d50 Remove placehold.it default (sorry) 2018-12-21 13:46:35 -06:00
gabrielburnworth 00183a86ba variable form updates 2018-12-20 20:52:52 -08:00
Rick Carlino 02baafb222
Add fragment table + FarmEvent parameters. 2018-12-20 14:40:45 -06:00
Rick Carlino befbdc4f0a Finally fix the symbol vs. string issues in CeleryScript type checker 2018-12-07 09:33:33 -06:00
Rick Carlino 904c98eff8 Add `farm_event` CS Node (for verification purposes only). NEXT: Edge case testing. 2018-12-06 20:50:34 -06:00
Rick Carlino 33344ae83d Idea I: Use the corpus for validation. 2018-12-06 15:01:21 -06:00
Rick Carlino d509d89db7 Remove in_use stuff from API 2018-11-17 11:07:45 -06:00
Rick Carlino eb6ba750b8 Bug fix for `updated_at` staleness noted by @connorrigby 2018-11-14 14:48:27 -06:00
Rick Carlino bc362028ef Fix blinky test 2018-11-13 07:51:35 -06:00
Rick Carlino cc33e90e57 Tests failing due to trailing 0 issue. 2018-11-09 11:41:52 -06:00
Rick Carlino d0f456931d Update faker usage. 2018-11-09 09:24:39 -06:00
Gabriel Burnworth 8bc0f2e2ae
maybe fix test 2018-11-05 13:54:20 -08:00
gabrielburnworth f9f21f6e5c add destroyAll feature 2018-11-02 13:09:03 -07:00
gabrielburnworth 314baf3854 differentiate coverage dirs 2018-11-02 12:52:55 -07:00
Rick Carlino 674c836d8a Removed `now` from sync object, forgot to update specs. Opps 2018-11-01 08:08:49 -05:00
Rick Carlino 7846554e79 add a new fixture sequence that has parameters. NEXT: Uncomment UI, tests 2018-10-25 11:47:01 -05:00
Rick Carlino 729026f90f Tests for all those new #show actions @connorrigby asked for 2018-10-24 11:43:02 -05:00
Rick Carlino 225c1f6176 Fix bork tests 2018-10-24 11:03:49 -05:00
Rick Carlino c2e38f4c20 Sprinkle performance on /sync endpoint 2018-10-24 10:20:14 -05:00
Rick Carlino ca34419de3 Try AppSignal 2018-10-24 08:12:09 -05:00
Rick Carlino 38ae6596ab Fix existing specs 2018-10-23 15:37:09 -05:00
Rick Carlino 8c4dc8d56f Sync endpoint 2018-10-20 19:25:39 -05:00
Rick Carlino 21b9c8051e Add updated_at to all the models 2018-10-18 21:54:25 -05:00
Rick Carlino 08b341f820 Merge conflicts 2018-10-18 11:13:14 -05:00
Rick Carlino 48d3ef856c Done with tests 2018-10-18 10:51:37 -05:00
Rick Carlino 63a7d7c8d1 WIP 2018-10-16 14:14:43 -05:00
Rick Carlino 5820025535 Forgot to merge master into staging 2018-10-15 11:50:34 -05:00
Rick Carlino 1e04d54992 Merge conflicts 2018-10-14 17:22:45 -05:00
Rick Carlino f666361ddb Added `sprouted` plant stage. NEXT: Update CeleryScript things. 2018-10-14 17:11:19 -05:00
Rick Carlino 72c4df8ebb Clear cache before running test 2018-10-08 09:40:46 -05:00
Rick Carlino 8d982b9e62 Remove more dead code, update CSP. NEXT: Fresh VM QA 2018-10-04 20:22:32 -05:00
Rick Carlino 72f0dc4c85 Tests for RmqConfigWriter 2018-10-04 15:38:10 -05:00
Rick Carlino b2c3bc1ff9 Shuffle files around better, remove more legacy references. Ready for one last QA round 2018-10-02 08:57:59 -05:00
Rick Carlino d0ba03da49
Merge branch 'staging' into thursday_fixes 2018-09-27 16:14:52 -05:00
Rick Carlino ae05154070 Demote CSP from :error to :info. No longer need to throttle log digests 2018-09-27 16:10:17 -05:00
Rick Carlino 51650849d4 Fix the typo in specs, too 2018-09-27 14:48:41 -05:00
Rick Carlino e8cbca9b73 Fix the typo in specs, too 2018-09-27 14:46:11 -05:00
Rick Carlino 8db88dfbe7 Done with tests, probably 2018-09-27 11:40:50 -05:00
Rick Carlino 6cd8e50a15 Update tests for KeyGen 2018-09-27 11:13:37 -05:00
Rick Carlino e750ab41e2 DRY up NervesHub spec 2018-09-26 15:40:33 -05:00
Rick Carlino 173deb15da Specs for DeviceCerts::Create 2018-09-26 15:18:14 -05:00
Rick Carlino b6065a0757 WIP 2018-09-26 13:15:51 -05:00
Rick Carlino 989d92c07f Add DeviceSerialNumber table 2018-09-26 11:53:49 -05:00
Rick Carlino 661def276a WIP 2018-09-26 11:08:50 -05:00
Rick Carlino 855385fd15 Tests for NerveHub.update(...) 2018-09-26 09:56:48 -05:00
Rick Carlino ee6e34c3e5 Remove class StubConn 2018-09-26 09:15:51 -05:00
Rick Carlino 00c0649f52 Update a test related to default values 2018-09-25 15:57:44 -05:00
Rick Carlino 08738e70e7 WIP 2018-09-25 14:14:14 -05:00
Rick Carlino cf84348f4f Convert method calls to constants, remove empty parameter lists. 2018-09-25 09:24:04 -05:00
Rick Carlino 679865e433 Spec: NervesHub.bad_http 2018-09-25 09:06:57 -05:00
Rick Carlino 65d5603801 Remove unused changes 2018-09-24 14:48:13 -05:00
Connor Rigby e23512c16a
NervesHub Rabbit worker.
This stops http requests from blocking
2018-09-24 09:53:04 -07:00
Connor Rigby f2b7054a16
Add NervesHub REST API implementation.
This is the all the code for the remote api calls
FarmBot API will need to make to NervesHub for
generating devices. No public access to this yet.
2018-09-20 12:53:21 -07:00
Rick Carlino c24d88e63c resource_type tests 2018-09-12 15:01:34 -05:00
Rick Carlino 656acb55fd Fix blinky test 2018-09-12 14:54:10 -05:00
Rick Carlino 7d7e884d66 Fix resource_update test, but now other tests are blinking... 2018-09-12 14:40:14 -05:00
Rick Carlino ac6e5387b3 Fix blinky test 2018-09-12 13:25:35 -05:00
Rick Carlino 026eca4a4d Increase coverage of Sequences::Update 2018-09-12 11:23:22 -05:00
Rick Carlino 072baef2db Merge conflicts 2018-09-06 13:34:06 -05:00
Rick Carlino 6442633474 Fix factorybot deprecation messages 2018-09-06 11:27:59 -05:00
Rick Carlino 14b8bec070 Comment out some tests 2018-08-23 09:20:10 -05:00
Rick Carlino 5066b039b9 Remove tests for old digest delivery logic 2018-08-18 11:17:57 -05:00
Rick Carlino b6ac26fa45
Domain Specific Access Control (#964)
Ability to restrict signups based on email domain.
2018-08-16 13:16:03 -05:00
Rick Carlino 623258c50f
Send message fix for `email` cahnnel (#961)
* fix for send_message emails
* Update log filtering rules in log digest delivery mailer
* Cleanup log digest email query, add tests for it
2018-08-16 09:59:38 -05:00
Rick Carlino 971b711e4e
Rename `device_configs` to `farmware_envs` (#960) 2018-08-15 13:44:04 -05:00
Rick Carlino 303a3491f2
Variables phase II, part II (#958)
* re-enable type checker
* Update celery script `execute` node to accept nested variable declarations
* Disable test button on parameterized sequences
* Fix unnoticed NPE
* Add `deep-cover` for greater coverage accuracy
* Spec for bad variable assignment
* Fix tests to allow parameter_declarations
* Disale the X/Y/Z boxes for parameters
* [FAILING] Make the ::Checker context (device) aware.
* [STABLE] Better `point_id` leaf validation.
* Add Sequence.parameterized?(id) helper
* Disallow parameterized FEs/RIs on server side.
* Add tests for parameter prevention stuff
* Default movement_keep_active_* to `1`
* Enable encoders by default
* Clean up frontend de-parameterization logic in farmevent/regimen editors
* Update specs to reflect new defaults
* stop dangerous edits
* Tests for regimen updates
* Maybe fix blinky coverage issues?
* Test for getVariable()
* Tests for handleSelect
* <TileMoveAbsSelect/> tests
* Update FBOS version parser
* tests for executer in TileSendMessage
* Tests for catchErrors()
2018-08-15 09:50:21 -05:00
Rick Carlino 92d8f7fc18
Update some default values (#956)
* Default movement_keep_active_* to `1`
* Enable encoders by default
2018-08-13 15:34:19 -05:00
Rick Carlino 2caa1684d6
Variables phase II, part I (#954)
* re-enable type checker 4 realz
* Update celery script `execute` node to accept nested variable declarations
* Disable test button on parameterized sequences (for now)
* Fix unnoticed NPE
* Add `deep-cover` for greater coverage accuracy
* Spec for bad variable assignment
2018-08-09 18:31:22 -05:00
Rick Carlino f25241350e
Add Timestamps to Log Digest Emails (#951)
First draft of "cascading" auto_sync to keep `in_use` flag synced with API.
2018-08-07 16:13:56 -05:00
Rick Carlino 72bcf0d6cb Fix tests 2018-08-02 16:03:40 -05:00
Rick Carlino 6117132e13 Batch creation done. Probably needs cleanup 2018-08-02 10:06:04 -05:00
Rick Carlino 6191dde789 Better handling of NOT_FOUND, more tests 2018-08-01 10:37:11 -05:00
Rick Carlino 99aeb625fc Write some specs 2018-07-31 14:48:53 -05:00
Rick Carlino 8b81317087 Change segment order for batch resource topics 2018-07-30 16:49:14 -05:00
Rick Carlino e97d3247b9 Formatting 2018-07-24 18:28:33 -05:00
Rick Carlino 8be88eb9ca Remove legacy MQ stuff in preparation for deploy 2018-07-24 18:25:16 -05:00
Rick Carlino 93291675f0 Fix auto-sync / upgrade FBJS 2018-07-24 17:14:20 -05:00
Rick Carlino d8cc65c8a8 Temporarily squelch failing test 2018-07-24 15:31:14 -05:00
Rick Carlino 29b7cea413 Update tests to reflect new UUID-less topic schema 2018-07-24 08:46:01 -05:00
Rick Carlino 9f713164c0 Friendlier names for Box LED pin_type 2018-07-23 14:51:02 -05:00
Rick Carlino 49af655b3b Cleanup specs and add better validation to CANT_ANALOG stuff 2018-07-23 12:39:18 -05:00
Rick Carlino 7525cf03e2 Cleanup 2018-07-23 11:32:08 -05:00
Rick Carlino 363b24be8f WIP 2018-07-23 10:52:49 -05:00
Rick Carlino 1a1e622115 Failure cases for Resources::Service.step2() 2018-07-23 09:53:24 -05:00
Rick Carlino ff6bf2be72 Fix broke test. Next: Manual QA against FBJS resource adapter 2018-07-23 08:57:39 -05:00
Rick Carlino beafb7738c Cleanup test output 2018-07-23 08:48:43 -05:00
Rick Carlino 894b91c79d New BoxLed pin_types 2018-07-22 14:07:57 -05:00
Rick Carlino e56a9ce247 Fix blinky pin_binding test (was occassionally picking off-limits pin_num) 2018-07-20 10:56:35 -05:00
Rick Carlino 23c8c0d262 Allow configuration / display of sensor_readings.mode 2018-07-20 10:37:09 -05:00
Rick Carlino 99752c14df Push up missing table updates 2018-07-19 21:42:00 -05:00
Rick Carlino 33150772e6 Merge conflict bloopers 2018-07-19 10:30:49 -05:00
Rick Carlino 3e58298d8f Spec updates 2018-07-19 10:26:45 -05:00
Rick Carlino 57c9293982 Updates to DB - PinBinding stuff. 2018-07-19 09:54:42 -05:00
Rick Carlino f41b2cc9f4 Fix point batch deletion spec 2018-07-18 08:31:30 -05:00
Rick Carlino a2772ef171 TODO: Fix test :thinking_face: 2018-07-17 17:38:00 -05:00
Rick Carlino bd663c3129 TODO: Tests for ::Job with `Point`, `Tool` 2018-07-17 16:44:03 -05:00
Rick Carlino 8d2cdcb09c Last few tests for ::Destroy meta classes 2018-07-17 16:38:03 -05:00
Rick Carlino 24325becde Cleanup 2018-07-17 16:02:49 -05:00
Rick Carlino 9c96f90a74 Works, needs cleanup 2018-07-17 15:50:09 -05:00
Rick Carlino 903e3ce1b5 :thinking_face: Weird class var mutation issues ... ? 2018-07-17 11:48:31 -05:00
Rick Carlino 60b85e4d38 Begin adding missing ::Destroy classes 2018-07-17 08:57:51 -05:00
Rick Carlino d21400a833 Remove debugger 2018-07-16 16:32:42 -05:00
Rick Carlino 9f25d8cf40 ✔️ 2018-07-16 16:29:06 -05:00
Rick Carlino ba89c2755c Coverage back to 💯. TODO: Fix blinky tests 2018-07-16 15:50:28 -05:00
Rick Carlino f120546907 Spec: reject batch operations on unauthorized resources 2018-07-16 15:42:48 -05:00
Rick Carlino 73a00a0047 Resources::Service.process base case specs 2018-07-16 15:30:17 -05:00
Rick Carlino 0656ea9240 Resources::Service.process failure cases 2018-07-16 15:16:07 -05:00
Rick Carlino ab0ec6c971 WIP 2018-07-16 14:09:03 -05:00
Rick Carlino 71e0c7edf0 Merge branch 'staging' of https://github.com/FarmBot/Farmbot-Web-App into resource_service 2018-07-16 13:53:53 -05:00
Rick Carlino 66156fc1d9 Base case specs for Resources::Job 2018-07-16 13:53:33 -05:00
Rick Carlino f5603b49ee JSON format error specs 2018-07-16 12:08:32 -05:00
Rick Carlino 199b37cfa1 Specs 2018-07-16 11:25:53 -05:00
Rick Carlino 575bd644df Fix broke log service test 2018-07-16 10:15:14 -05:00
Rick Carlino 4cd6e39576 Blinky tests? 2018-07-16 09:51:31 -05:00
Rick Carlino b361b8ffff Wip 2018-07-15 21:21:10 -05:00
Rick Carlino 07b19d5474 Merge branch 'staging' of https://github.com/FarmBot/Farmbot-Web-App into resource_service 2018-07-15 21:12:29 -05:00
Rick Carlino 07267e963f Comment cleanup 2018-07-15 12:31:48 -05:00
Rick Carlino 4591d7260f Specs for enforcing pin 17/23 validations 2018-07-15 12:21:20 -05:00
Rick Carlino 41a5e1ac95 [UNSTABLE] Tests for mutual exclusivity 2018-07-13 16:17:50 -05:00
Rick Carlino e0a0f8f11e [UNSTABLE][WIP] Need to finish moving files into correct dirs, coverage, and adding batch support to more resources. #squashThis 2018-07-13 13:07:50 -05:00
Rick Carlino 4134a893f6 Tests and junk cleanup 2018-07-13 10:56:45 -05:00
Rick Carlino fe8fe4d9de Allow floats in X/Y/Z 2018-07-13 08:04:41 -05:00
Rick Carlino 47e773c2b2 Merge branch 'staging' of https://github.com/FarmBot/Farmbot-Web-App into resource_service 2018-07-12 10:57:46 -05:00
Rick Carlino 6873f34f94 💯 percent coverage 2018-07-12 10:21:53 -05:00
Rick Carlino 67ecd0df73 Tests for eviction method 2018-07-12 09:51:53 -05:00
Rick Carlino 80a502a7c8 [UNSTABLE] Revert public sequence stuff for now 2018-07-11 16:16:57 -05:00
Rick Carlino f66ea81ded WIP 2018-07-11 11:51:02 -05:00
Rick Carlino f3f1782c2e [UNSTABLE] Add `permissions` table. 2018-07-11 09:44:52 -05:00
Rick Carlino f4ee8cfcf0 Move services around 2018-07-10 08:31:25 -05:00
Rick Carlino 7ecf3ab575 Rename Sequences::Delete => Sequences::Destroy 2018-07-08 11:53:30 -05:00
Rick Carlino c14656d51c Tests for TokenIssuance.clean_old_tokens 2018-07-08 11:35:47 -05:00
Rick Carlino 0fd9859b02 Tests for TokenIssuance#maybe_evict_clients 2018-07-07 10:58:24 -05:00
Rick Carlino 5b8bee38e8 Create CleanOutOldDbItemsJob 2018-07-07 10:27:55 -05:00
Rick Carlino d4cd3c7cfb Transport::Mgmt tests 2018-07-06 08:42:13 -05:00
Rick Carlino e7e19b6481
Merge branch 'staging' into email_encoding_issues 2018-06-26 18:24:22 -05:00
Rick Carlino d623226dbe Allow UTF-8 logs. 2018-06-26 18:22:51 -05:00
Rick Carlino f5aaf2dd4e Add `created_at` to SensorReadingSerializer 2018-06-26 14:12:41 -05:00
Rick Carlino 048517db3e Add more specs for new logic 2018-06-25 15:11:19 -05:00
Rick Carlino 4c4c28493a Add tests 2018-06-25 13:07:47 -05:00
Rick Carlino a9e9765ec8 👏 Fix blinky test 2018-06-23 08:09:04 -05:00
Rick Carlino 3d99cf1089 ✔️ 2018-06-23 07:48:01 -05:00
Rick Carlino 9985ab3b76 Tests for RmqUtilController 2018-06-23 07:40:14 -05:00
Rick Carlino 9f2c27844b Add specs 2018-06-23 06:23:43 -05:00
Rick Carlino 110d7acd87
Diagnostic Dumps - RC 1 (#889)
Add API side diagnostic reporting.
2018-06-18 16:12:00 -05:00
Rick Carlino 35f5575e10
Rollbar Changes (#882)
* README updates

* Get rid of LogDispatch table

* More transactions.

* Prevent Log::RateLimitError errors after migration

* Re-raise errors to Rollbar in the log service

* Update rollbar stuff.

* Bundle outdated

* Yarn outdated

* Add test for current_device_id
2018-06-11 16:13:29 -05:00
Rick Carlino 984d47762b
Bug Fixes, Docs, Refactorings (#881)
* README updates
* Get rid of LogDispatch table
* More transactions.
* Prevent Log::RateLimitError errors after migration
2018-06-09 11:58:01 -05:00
Rick Carlino 4d7ef0c6e8
More filters, dep upgrades (#873) 2018-05-31 08:54:07 -05:00
Rick Carlino b49b128c60 Search by type 2018-05-25 09:24:34 -05:00
Rick Carlino 55e61b1132 Tests for Ruby code 2018-05-23 08:53:43 -05:00
Rick Carlino fb26b24dab Rename: Throttler => TimePeriod 2018-05-23 08:38:17 -05:00
Rick Carlino 3e464e30a7 Move subclasses into files 2018-05-23 08:32:06 -05:00
Rick Carlino b3a30dd027 Works! 2018-05-22 16:02:22 -05:00
Rick Carlino 422b03af60 Fix Device#maybe_throttle 2018-05-22 15:45:26 -05:00
Rick Carlino 78ba739c1d Explain policy violations in toast 2018-05-22 15:36:05 -05:00
Rick Carlino 0676f36a60 Stub some things out, write test for Device#is_device 2018-05-22 11:30:29 -05:00
Rick Carlino f9d6966a02 Fix tests so they pass in locations outside of Chicago :-P 2018-05-21 15:16:44 -05:00
Rick Carlino 6075b1125b Tests done. Next: conditional log message for cooldown period 2018-05-21 14:12:36 -05:00
Rick Carlino 92b88f44dc Device#maybe_unthrottle specs 2018-05-21 13:57:04 -05:00
Rick Carlino 7b8eacb7fd Marshal.load bugfix + `maybe_throtle` tests. 2018-05-21 13:54:13 -05:00
Rick Carlino bb55058d53 Test fix for caching stuff 2018-05-21 13:30:41 -05:00
Rick Carlino 49d03db3e6 Device#cached_find tests 2018-05-21 13:17:12 -05:00
Rick Carlino 9f78fc11f2 Changes to accomodate new throttle message 2018-05-21 09:30:25 -05:00
Rick Carlino ddd8c03ced Specs / implementation for Throttler#when_does_next_period_start? 2018-05-21 08:39:18 -05:00
Rick Carlino edc2caebcf Tests for AmqpLogParser edge cases 2018-05-20 18:36:20 -05:00
Rick Carlino 5982532e38 Seperate parsing / validation concerns out of `LogService` 2018-05-20 17:17:59 -05:00
Rick Carlino 3d0a9b6b44 Done 2018-05-18 14:21:04 -05:00
Rick Carlino e5106f93c8 ThrottlePolicy#attempt_throttled_action 2018-05-18 13:44:35 -05:00
Rick Carlino 2a5f0a3c91 ThrottlePolicy + tests. NEXT: ThrottlePolicy#attempt 2018-05-18 13:13:45 -05:00
Rick Carlino 1de2121554 Start ThrottlePolicy class 2018-05-18 11:46:02 -05:00
Rick Carlino 4bdb6713d2 Add throttler class 2018-05-18 11:21:15 -05:00
Rick Carlino 06174e00c7 New DB indexes, update Rails. 2018-05-18 08:30:36 -05:00
Rick Carlino 7e0957d580 More tests 2018-05-12 09:26:47 -05:00
Rick Carlino e8a3c8caa3 Tests and file (image) removal 2018-05-12 09:24:30 -05:00
Rick Carlino d95f5b0791 Add CalculateUpgrade::NULL 2018-05-10 12:59:57 -05:00
Rick Carlino e8e9368da0 Unbork specs 2018-05-08 08:48:39 -05:00
Rick Carlino 8371dbd861 Merge branch 'staging' of https://github.com/FarmBot/Farmbot-Web-App into seq_body_bug 2018-05-08 08:44:58 -05:00
Rick Carlino 7af7270f3b Possible fix I 2018-05-07 16:37:54 -05:00
Harry Brundage e6c57e6a90 Fix a test accidentally leaving User::SKIP_EMAIL_VALIDATION state dirty 2018-05-07 17:11:04 -04:00
Harry Brundage 97c8c51663 Fix a test failing when NO_EMAILS is true in the config for DeviceController#dump 2018-05-07 17:11:04 -04:00
Rick Carlino dcf37c4967 Update tests 2018-05-07 10:40:14 -05:00
Rick Carlino 9dfa5c57bc [WIP] Add new meta fields to data dump 2018-05-07 09:57:02 -05:00
Rick Carlino 27c730ea13
Merge branch 'staging' into docs_cleanup 2018-05-04 16:15:47 -05:00
Rick Carlino 019b231a2c Tests 2018-05-04 13:26:53 -05:00
Rick Carlino cea0028bb7 Merge branch 'staging' of https://github.com/FarmBot/Farmbot-Web-App into local_images 2018-05-04 11:55:48 -05:00
Rick Carlino 85cb133025
Merge branch 'staging' into docs_cleanup 2018-05-04 11:38:15 -05:00
Rick Carlino 34a39f38fc Remove YAGNI stuff from corpus controller 2018-05-04 10:42:51 -05:00
Rick Carlino ab242637b8 Add more export resources 2018-05-04 09:11:52 -05:00
Rick Carlino 0751e5f42f Specs for stub policy use case 2018-05-04 07:20:49 -05:00
Rick Carlino 43f68b7b30 Done with tests for requestAccountExport() 2018-05-03 10:42:12 -05:00
Rick Carlino 320f902eb4 Stub out the `NO_EMAILS` version of data dump 2018-05-02 16:40:25 -05:00
Rick Carlino 92ac9a7619 Fix issue where data_dump `status` where erroneously `inactive` 2018-05-02 14:56:47 -05:00
Rick Carlino 831e4098bc Re-enable call to user#reset_confirmation_token 2018-05-01 17:17:47 -05:00
Rick Carlino 936a269000
Merge branch 'staging' into reset-confirmation-tokens 2018-05-01 17:10:05 -05:00
Rick Carlino 1a49ec9d2d Merge branch 'no-emails-update-user-test' of https://github.com/airhorns/Farmbot-Web-App into no-emails-update-user-test 2018-05-01 16:36:32 -05:00
Harry Brundage b1ec335ebc Reenable confirmation token resetting for user email updates
I think this functionality was accidentally disabled in
65b044d7a8 . When a user changes their
email, an email is sent to the new email to ensure the user actually
owns that new email and isn't sending emails to people that aren't them. A secret token is
sent in that email and the user is only allowed to change their email if
they can prove they know the secret that was only sent to that email.

This scheme breaks down if the secret is shared with multiple emails.
Not that this is likely, but a user *could* change their email once to
an email they control, and get a secret to confirm that email. If that
user then changed their email again to a target email they want to spam,
and they knew that the same confirmation secret was used to confirm that
second new email, they could craft and visit a link that confirmed it
without ever having recieved the second confirmation email. That would
allow them to spam the target email if the application sends lots of
emails.

Long story short, the app used to this, and while its a bit farfetched
it may as well continue to do this.

This commit uncomments the line and adds a test.
2018-05-01 10:36:52 -04:00
Harry Brundage 2143ae2394 Make Users::Update update emails when NO_EMAILS is set
With NO_EMAILS set (say in a dev environment), some pieces of the User update mutation are skipped. Running the tests for Users::Update on a fresh clone of master with NO_EMAILS set had a failing test:

```
Failures:

  1) Users::Update changes email addresses
     Failure/Error: expect(u.unconfirmed_email?).to be true

       expected true
            got false
     # ./spec/mutations/users/update_spec.rb:31:in `block (2 levels) in <top (required)>'
     # /Users/airhorns/.rbenv/versions/2.5.1/bin/rspec:23:in `load'
     # /Users/airhorns/.rbenv/versions/2.5.1/bin/rspec:23:in `<top (required)>'
     # /Users/airhorns/.rbenv/versions/2.5.1/bin/bundle:23:in `load'
     # /Users/airhorns/.rbenv/versions/2.5.1/bin/bundle:23:in `<main>'
```

This test failed because it was expecting against the `unconfirmed_email` attribute, which in the NO_EMAILS case, isn't used at all. So, the test now checks if email verification is on, and expects against `unconfirmed_email` if so, and the actual `email` attribute otherwise.

Turns out, that test failed too! The actual code in `Users::Update` figured out that direct email mutations should be allowed when NO_EMAILS is set, but didn't pass that down to the `#update_attributes` call. I think this was just a small mistake because the code builds a list of attribute exclusions conditional on NO_EMAILS already, and just never uses it. This code was added in 65b044d7a8 which looks like it might not have been intended to hit master. No matter, easy fix!
2018-05-01 10:28:04 -04:00
Harry Brundage 7594dbe838 Make Users::Update update emails when NO_EMAILS is set
With NO_EMAILS set (say in a dev environment), some pieces of the User update mutation are skipped. Running the tests for Users::Update on a fresh clone of master with NO_EMAILS set had a failing test:

```
Failures:

  1) Users::Update changes email addresses
     Failure/Error: expect(u.unconfirmed_email?).to be true

       expected true
            got false
     # ./spec/mutations/users/update_spec.rb:31:in `block (2 levels) in <top (required)>'
     # /Users/airhorns/.rbenv/versions/2.5.1/bin/rspec:23:in `load'
     # /Users/airhorns/.rbenv/versions/2.5.1/bin/rspec:23:in `<top (required)>'
     # /Users/airhorns/.rbenv/versions/2.5.1/bin/bundle:23:in `load'
     # /Users/airhorns/.rbenv/versions/2.5.1/bin/bundle:23:in `<main>'
```

This test failed because it was expecting against the `unconfirmed_email` attribute, which in the NO_EMAILS case, isn't used at all. So, the test now checks if email verification is on, and expects against `unconfirmed_email` if so, and the actual `email` attribute otherwise.

Turns out, that test failed too! The actual code in `Users::Update` figured out that direct email mutations should be allowed when NO_EMAILS is set, but didn't pass that down to the `#update_attributes` call. I think this was just a small mistake because the code builds a list of attribute exclusions conditional on NO_EMAILS already, and just never uses it. This code was added in 65b044d7a8 which looks like it might not have been intended to hit master. No matter, easy fix!
2018-05-01 10:12:23 -04:00
Rick Carlino f56aa55843 Remove old pointer_id=0 refs 2018-05-01 08:11:09 -05:00
Rick Carlino df8ffd59fa Remove legacy point artifacts 2018-05-01 07:39:36 -05:00
Rick Carlino 0dfeff0777 DataDump#email_json_dump tests 2018-04-30 09:32:35 -05:00
Rick Carlino efa2f8bcfd DataDump#email_json_dump works, needs tests. 2018-04-30 09:03:09 -05:00
Rick Carlino 3a9edd9f2a ✔️ TODO: Email JSON attachment. 2018-04-28 12:00:58 -05:00
Rick Carlino caacc36f04 Merge branch 'garden_snapshot_ii' into data_dump 2018-04-28 10:13:46 -05:00
Rick Carlino 097f5b3ace Update test for devices#dump 2018-04-28 10:08:01 -05:00
Rick Carlino 7169ee78a4 Merge conflict, schema.rb 2018-04-28 08:54:37 -05:00
Rick Carlino 8a4c6fa8b1 Update tests for singular error messages 2018-04-27 11:03:33 -05:00
Rick Carlino 005bdd1fca WIP 2018-04-27 07:14:45 -05:00
Rick Carlino 76504f8941 Moar old stuff. 2018-04-26 18:13:24 -05:00
Rick Carlino 4bafd354c6 Remove old tests 2018-04-26 18:10:28 -05:00
Rick Carlino 52916bec4c 🎉 2018-04-26 18:04:28 -05:00
Rick Carlino f8c7fee18a 💯 2018-04-26 18:02:29 -05:00
Rick Carlino cbfc52e396 WIP 2018-04-26 17:57:37 -05:00
Rick Carlino 0b5848ef14 Stub FakeTransport compeltely 2018-04-26 17:16:25 -05:00
Rick Carlino 4bd60324b7 Ability to change `Transport` AMQP adapter at runtime. 2018-04-26 11:51:48 -05:00
Rick Carlino 923794fcbd Remove tests that treat `Transport` as a singleton 2018-04-26 11:15:47 -05:00
Rick Carlino 30fdf4bc63 [UNSTABLE] De-singleton-ify `Transport` module 2018-04-26 11:02:11 -05:00
Rick Carlino 5bb7478e88 Add tests for saved garden application errors 2018-04-26 10:55:24 -05:00
Rick Carlino 5718714202 Merge conflict, schema.rb 2018-04-26 10:10:53 -05:00
Rick Carlino 9efd2aa5f2 Point#is_infinite? tests / factoring 2018-04-24 21:06:07 -05:00
Rick Carlino 16ff5543d9 Make log#type optional at the controller level, too. 2018-04-23 20:54:18 -05:00
Rick Carlino 6a536b2cb4 Possible fix CC: @connorRigby 2018-04-23 14:37:51 -05:00
Rick Carlino 9f3c8d9c4d [UNSTABLE] TODO: Add `device_id` column to `InUsePoint` view. 2018-04-23 12:15:12 -05:00
Rick Carlino 513a8e243f More default verbosity tweaks 2018-04-21 08:58:23 -05:00
Rick Carlino 6abbf2a654 Fix HSTORE query to support partial matches 2018-04-21 08:39:40 -05:00
Rick Carlino adcd6f395c LEFT OUTER JOIN rather than INNER JOIN 2018-04-20 14:29:29 -05:00
Rick Carlino f977eb63da Cleanup tests 2018-04-20 12:30:44 -05:00
Rick Carlino a71024cbf6 Nondestructive #apply 2018-04-20 09:41:10 -05:00
Rick Carlino a22b4d761e Apply ✔️ 2018-04-20 08:49:21 -05:00
Rick Carlino 4232f889b9 Merge branch 'staging' of https://github.com/FarmBot/Farmbot-Web-App into backscheduling 2018-04-19 10:38:24 -05:00
Rick Carlino 366011d26d Allow backscheduling 2018-04-19 10:38:07 -05:00
Rick Carlino 4b67027720 Done. 2018-04-19 09:52:31 -05:00
Rick Carlino 2e5f278f6a [STABLE] First batch of tests for PlantTemplates 2018-04-19 09:43:55 -05:00
Rick Carlino 7179e99759 Rename `garden` to `saved_garden` 2018-04-19 08:33:16 -05:00
Rick Carlino b1bb361556 Tests for all GardensController endpoints. NEXT: PlantTemplateController 2018-04-18 17:38:40 -05:00
Rick Carlino 492c601795 Test for Gardens#index 2018-04-18 17:17:00 -05:00
Rick Carlino 69c24994c3 Merge branch 'staging' of https://github.com/FarmBot/Farmbot-Web-App into saved_gardens 2018-04-18 15:45:10 -05:00
Rick Carlino e85e827816 Use mocks for now 2018-04-18 15:29:53 -05:00
Rick Carlino b674c48830 [WIP] Works, but tests need updates. 2018-04-18 11:49:55 -05:00
Rick Carlino 757c00ca12 Update test suite to reflect verbiage changes 2018-04-18 08:36:14 -05:00
Rick Carlino 6ab5242c64 Verbiage change 2018-04-16 12:26:55 -05:00
Rick Carlino 116234fa12 WIP 2018-04-16 11:17:19 -05:00
Rick Carlino f7f5cf8b9c Post cleanup 2018-04-16 10:26:13 -05:00
Rick Carlino 550d1616bf Tweak point deletion error verbiage 2018-04-16 10:22:13 -05:00
Rick Carlino 683a4c4a89 Simplify GlobalConfig bootstrapping 2018-04-13 14:34:23 -05:00
Rick Carlino e5996da209 [UNSTABLE] WIP 2018-04-13 14:14:34 -05:00
Rick Carlino fefe41df27 Bump FBOS version 2018-04-13 13:46:56 -05:00
Rick Carlino c1c78e0bd4 One last dead code removal 2018-04-12 14:34:05 -05:00
Rick Carlino 592d0ba30f ✔️ 2018-04-12 14:20:19 -05:00
Rick Carlino 3b1ed30347 [UNSTABLE] Add more indexes, default verbosity 2018-04-12 14:16:06 -05:00
Rick Carlino a0f038e89d Done with point archival 2018-04-11 15:46:49 -05:00
Rick Carlino 6cc8d87c06 More test cases 2018-04-11 09:16:54 -05:00
Rick Carlino 2040feece1 Ability to discard points 2018-04-10 13:37:23 -05:00
Rick Carlino 4d3789c323 Tests for gradual migrater 2018-04-10 08:55:58 -05:00
Rick Carlino ed62e2dddf Test coverage 🆙. NEXT: Tests for `#do_migrate`, deploy. 2018-04-10 08:10:45 -05:00
Rick Carlino 91aa7cc466 [UNSTABLE] Scrap ::LegacyMigration idea, set self.inheritence_column. TODO: Fix serialization issues 2018-04-09 18:13:44 -05:00
Rick Carlino baa2b61bba PlantSerializer fixes 2018-04-08 21:34:36 -05:00
Rick Carlino 174e934f25 NEXT: pointer_id / pointer_type removal 2018-04-08 21:10:42 -05:00
Rick Carlino 235b0e2df5 Remove even more old refs to pointer_type/ pointer_id 2018-04-08 20:36:11 -05:00
Rick Carlino b4a13431c8 WIP 2018-04-07 17:02:33 -05:00
Rick Carlino 82cb15a4b5 Fixes to celeryscript `pointer_type` validation 2018-04-07 16:38:11 -05:00
Rick Carlino 72be854dcd Cleanup tests and error messages 2018-04-07 15:09:31 -05:00
Rick Carlino 4b9703d1a8
Merge branch 'staging' into logs_500_err 2018-04-06 08:33:18 -05:00
Rick Carlino 759a5cca80 Fix 500 error when missing fields on log creation 2018-04-06 08:31:26 -05:00
Rick Carlino f3531ac7ac Remove code no longer used after introduction of SQL views 2018-04-06 07:56:15 -05:00
Rick Carlino 8d5bf03e40 Ready for QA 2018-04-05 17:58:57 -05:00
Rick Carlino c69e4d42d3 ✔️ Needs further testing. 2018-04-05 15:37:36 -05:00
Rick Carlino 16c156eeb0 Test case set, needs new verbiage 2018-04-05 14:56:02 -05:00
Rick Carlino e4aea4d0f4 Modifications in prep. for table changes 2018-04-04 16:24:25 -05:00
Rick Carlino 578bb90850 Migration repair 2018-04-04 14:41:03 -05:00
Rick Carlino 1c32a7b315 New logs path 2018-04-03 16:49:21 -05:00
Rick Carlino bdf24d22f7 Add specs for non-legacy API POST to api/logs 2018-04-02 15:20:10 -05:00
Rick Carlino 4c630d57dd Text coverage bump 2018-04-01 07:57:14 -05:00
Rick Carlino 85b43b16a3
Merge branch 'staging' into logs_perf 2018-03-31 11:54:59 -05:00
Rick Carlino 3892650f5c Tests for device#tell 2018-03-31 11:53:25 -05:00
Rick Carlino cd7d8186b0 Serverside filtering updates 2018-03-31 10:42:13 -05:00
Rick Carlino afac64c98c Update tests 2018-03-31 09:35:51 -05:00
Rick Carlino 6fc9bb1a67 Add tests, too 2018-03-30 16:19:30 -05:00
Rick Carlino 2c80758282 🎉:question_mark: (Still needs tests) 2018-03-30 16:05:53 -05:00
Rick Carlino 1eb2f5b96a Start logs#search 2018-03-30 14:56:21 -05:00
Rick Carlino d8c37437e7 Move shim out of serializer into model 2018-03-30 13:23:22 -05:00
Rick Carlino 96be999c68 Shims for eventual `meta` field removal 2018-03-30 10:36:28 -05:00
Rick Carlino 4f76be4059 Dead code removal 2018-03-28 17:04:54 -05:00
Rick Carlino 69029fc3ae Tests for token revocation part II 2018-03-28 17:02:51 -05:00
Rick Carlino 20dd1ed289 Tests for token revocation 2018-03-28 16:43:38 -05:00
Rick Carlino ef3259f664 Token issuance table (DRAFT) 2018-03-28 16:28:21 -05:00
Rick Carlino 0a6a74b067 Broadcast factory reset on password change ✔️ 2018-03-28 14:29:16 -05:00
Rick Carlino 5ff5c53e8e Merge branch 'staging' of https://github.com/FarmBot/Farmbot-Web-App into pw_reset_fact_reset 2018-03-28 14:28:32 -05:00
Rick Carlino 216d2c7445 Merge branch 'staging' of https://github.com/FarmBot/Farmbot-Web-App into pw_reset_fact_reset 2018-03-28 13:17:28 -05:00
Rick Carlino 82c6649a33
Merge branch 'staging' into utc_offset_adjust 2018-03-28 11:27:08 -05:00
Rick Carlino fdd68eabc3 Broadcast factory reset on password change DRAFT 2018-03-28 11:26:41 -05:00
Rick Carlino 74ac8d2555 ✔️ 2018-03-28 11:05:40 -05:00
Rick Carlino b37b7cad97 WIP- add factoryResetJob 2018-03-28 10:38:44 -05:00
Rick Carlino 71fa3a1d02 Nondeterministic test failures 2018-03-28 09:29:11 -05:00
Rick Carlino 6bbc69b5e7 Tests 2018-03-26 15:51:36 -05:00
Rick Carlino 4f65857e86 Merge conflicts 2018-03-26 13:00:02 -05:00
Rick Carlino 38b2967de3 Add tests 2018-03-26 12:56:55 -05:00
Rick Carlino 3bad3a29a1 Merge conflicts 2018-03-26 12:30:18 -05:00
Rick Carlino 623f660ee6 `critical_email` channel + mailers 2018-03-26 10:35:54 -05:00
Rick Carlino 6f76f7cf72 Make the default device name `Farmbot` 2018-03-25 17:11:17 -05:00
Rick Carlino ed6fa145e4 Fix blinky test 2018-03-24 09:16:17 -05:00
Rick Carlino 0ba46da967 Tests for GlobalConfig 2018-03-24 08:45:26 -05:00
Rick Carlino 2b575f9914 Add `GlobalConfig` model 2018-03-23 14:29:41 -05:00
Rick Carlino a1b19d579d Tests for the in_use flag 2018-03-23 09:49:44 -05:00
Rick Carlino 62aa6838e0 Ruby Tests 2018-03-21 12:17:43 -05:00
Rick Carlino 4fce5e54e2 Remove SequenceSerializer 2018-03-21 09:27:29 -05:00
Rick Carlino c176da6a92 ✔️ 2018-03-21 09:10:31 -05:00
Rick Carlino ab54e23e94 Everything works again except for sequence autosync. 2018-03-21 08:44:33 -05:00
Rick Carlino 41e5d6a355 Root cause: auto sync mechanism. :thinking_face: 2018-03-21 08:15:01 -05:00
Rick Carlino 9ee9688699 Why is there no "sequence" EdgeNode? 2018-03-20 16:31:30 -05:00
Rick Carlino 25196a3c21 🎉 Tests pass. Next: erase `body` and `args` properties from model 2018-03-20 15:56:34 -05:00
Rick Carlino 86ce87e5e8 4 failures remain 2018-03-20 15:48:09 -05:00
Rick Carlino de156d61e5 WIP: Adding `FakeSequence.build` wrapper 2018-03-20 15:30:52 -05:00
Rick Carlino d82515e9b4 DRY up mutations attribute declaration. NEXT: Fix FactoryBot.create(:sequence) 2018-03-20 14:43:34 -05:00
Rick Carlino d2933224d4 WIP 2018-03-20 13:38:24 -05:00
Rick Carlino eb38a39fc2 Remove unused specs 2018-03-20 09:50:16 -05:00
Rick Carlino db3d3911ad Stop allowing email (string) in sub field (deprecated) 2018-03-18 10:38:52 -05:00
Rick Carlino e6af62fbfe Irrelevant TODO removal 2018-03-18 10:23:00 -05:00
Rick Carlino 80998b568b Merge branch 'staging' of https://github.com/FarmBot/Farmbot-Web-App into deprecations 2018-03-16 15:47:52 -05:00
Rick Carlino 96b8b7c704 Remove calendar 2018-03-16 15:47:15 -05:00
Rick Carlino 45702da703 Add performance to sequences#index 2018-03-16 10:40:27 -05:00
Rick Carlino f1f876d404 Simplify queries 2018-03-16 10:02:50 -05:00
Rick Carlino 4edc909c06 Update specs 2018-03-15 16:33:59 -05:00
Rick Carlino 2e0b7b288c Validate email/pw when signing transfer control cert 2018-03-12 13:44:06 -05:00
Rick Carlino 035cab9ca5 Endpoint done 2018-03-12 08:48:27 -05:00
Rick Carlino f33652d545 Start idea #2 2018-03-11 19:11:24 -05:00
Rick Carlino 19a67056cf Change default of encoder_scaling_* 2018-03-10 16:20:41 -06:00
Rick Carlino 84515c2896 Fix dep tracking / prevent deletion of in use points 2018-03-07 16:38:29 -06:00
Rick Carlino e0376d5162 [UNSTABLE] Tests in place, make them pass. 2018-03-07 15:27:16 -06:00
Rick Carlino 06d20211ff Bug where tests fail on Travis 2018-03-06 08:51:29 -06:00
Rick Carlino 07c84ce36f Fix bug in re-verification 2018-03-06 08:17:12 -06:00
Rick Carlino 189f8b291f Planted_at column 2018-03-01 16:39:45 -06:00
Rick Carlino 016782297e Friendlier errors when dep checking pin bindings. 2018-03-01 16:08:31 -06:00
Rick Carlino 0a229b786a Revamp user verification 2018-03-01 15:35:44 -06:00
Rick Carlino 65b044d7a8 WIP 2018-03-01 14:48:18 -06:00
Rick Carlino b4b90b0943 WIP: Move verification specs 2018-03-01 10:21:53 -06:00
Rick Carlino a1e2dc7088 WIP: Remove `verify` from webpack bundle 2018-02-28 16:06:53 -06:00
Rick Carlino b31fea3f88 Test for sequence_id validator 2018-02-28 11:43:52 -06:00
Rick Carlino a39fd6f5b1 Fix foreign key errors in test suite 2018-02-28 11:38:05 -06:00
Rick Carlino d4ded90072 Mostly working pin_binding api endpoint 2018-02-28 11:08:41 -06:00