Commit Graph

17 Commits (2c94f155840b49639b8bf1ec996d99e268fa9a52)

Author SHA1 Message Date
Adeeb Shihadeh 2c94f15584
linter: don't allow implicitly concatenated strings (#23513)
* linter: don't allow implicitly concatenated strings

* fix hyundai
2022-01-13 14:19:38 -08:00
Jason Young b49f518782
GM: EPS fault workaround (#22404)
* seems legit

* panda -> loopback

* fix comment

* add some "why" comments for the next guy

* re-test with stock 50Hz rate

* ugly test

* Update selfdrive/car/gm/carstate.py

Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>

* update refs

* Update selfdrive/car/gm/carstate.py

Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-28 16:54:12 -07:00
Gibby 46009fa6fd
GM: 2016 Escalade ESV (#22670)
* Added 2016 Escalade ESV fingerprint and data.

* Updated CARS.md for GM vehicles

* Uploaded Escalade fingerprint

* Removed part about auto high beams for GM. Seems to work for some.

* Revert other modifications in CARS.md

* Revert other modifications in CARS.md

* Added test route for Escalade

* Added tunning for Escalade to reduce jerky steering

* Apply suggestions from code review

* Update selfdrive/car/gm/interface.py

* cleanup test route

Co-authored-by: Gibby <git@twoitguys>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-26 15:59:24 -07:00
qadmus ca476650e9
GM: Cleanup & format values.py (#22671)
* cleanup & format gm/values.py like toyota/values.py

* Units and notes
2021-10-25 23:46:44 -07:00
Willem Melching f941111dcd
Clean up PID controller ACCEL_MIN/ACCEL_MAX (#22148)
* use ISO 15622:2018 limits in PID controller

* allow more for nidec

* limit PID inputs

* CP is not needed

* add GM

* not used

* update ref

* fix honda bosch
2021-09-06 17:29:32 -07:00
HaraldSchafer 1ac89f14aa
Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-30 09:32:52 -07:00
Dave c0e25a8f29
Add Acadia Denali 2018 fingerprint (#21545) 2021-07-10 13:23:55 -07:00
Willem Melching e4cf43c6fc
Move all CarControllerParams into values.py (#19663)
* toyota

* use scale from values.py

* nissan

* subaru

* honda

* gm

* toyota combine into CarControllerParams

* nissan refactor

* chrysler refactor

* mazda refactor

* hyundai refactor

* subaru refactor
2021-01-06 11:20:44 +01:00
Adeeb Shihadeh 47c21f10f5
grey panda is unsupported (#2458) 2020-11-03 19:56:25 -08:00
Adeeb Shihadeh 472fe66962
GM cleanup + ignition fix (#1729)
* small cleanup

* alertmanager handles that

* improve tuning

* below steer speed

* Revert "improve tuning"

This reverts commit 5d2de147d2.

* bump panda

* update refs

* bump panda
2020-06-18 12:24:47 -07:00
Adeeb 367155168a
Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
2020-06-03 16:13:34 -07:00
Adeeb 6051061ff8
Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
2020-05-31 00:48:47 -07:00
Adeeb e22482eb31
Remove Cadillac CT6 port (#1359)
* remove CT6 port

* dont need this route

* extra char

* fix carcontroller params
2020-04-13 15:53:24 -07:00
Adeeb 13f60eae91
Abstract CarInterface init (#1131)
* abstract CarInterface init

* unused

* subaru

* gm cleanup

* vw

* typo

* carcontroller

* more cleanup

* fix vw
2020-02-19 20:37:07 -08:00
rbiasini 5c52be27ca
abstract kf and gear parser as static methods (#1103)
* Before abstraction, adding speed init from VW as well

* strting to abstract carstate class

* fix bug and update lock?

* revert pipfile change

* another bug

* fix linter

* bug fix

* remove a bunch of diplicated kf code

* better to not have class vars. will abstract __init__ anyway later

* Abstract gear parser static method (#1107)

* abstract common instance vars in carstate init and a generic gear parser static method

* update opendbc (#1105)

* abstract gear parser for chrysler

* update opendbc (#1106)

* abstract gm gear parser too

* remove unnecessary random vars
2020-02-17 11:53:53 -08:00
Adeeb dafdb79db2 Clean up ECU redundancy in selfdrive/car/* (#963)
* clean up ecu redundancy in selfdrive/car

* clean up gear parsing
2020-01-18 23:35:10 -08:00
George Hotz 71ead9adea selfdrive/car 2020-01-17 10:58:43 -08:00