Commit Graph

45 Commits (5c3f3e44bc7b25c9ce502419bcd0261c12ec2b0d)

Author SHA1 Message Date
Adeeb Shihadeh 5c3f3e44bc
break up selfdrive.config (#23959)
* break up selfdrive.config

* add to release files

* fix import order
2022-03-13 21:42:39 -07:00
Adeeb Shihadeh 87849f93b1
better steer fault names (#23890)
* better steer fault names

* bump cereal
2022-03-01 22:53:55 -08:00
Shane Smiskol 61de3788ff
CANParser: remove rest of default values (#23676)
* forgot honda somehow!

* forgot some more signal defaults
2022-01-31 17:29:55 -08:00
Shane Smiskol 95caa5f399
CANParser: consistent style for adding signals/checks (#23646)
* consistent style, like toyota

* typo
2022-01-28 13:20:13 -08:00
Shane Smiskol 3645186d7c
CANParser: remove default values (#23642)
* draft

* remove rest

* bump

* update radar interfaces

* do rest and formatting

* bump

* fix mising check

* try this

* Revert "try this"

This reverts commit 0d26d9a072.

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-01-27 17:06:18 -08:00
Willem Melching e6180738fd
add CarParams.wheelSpeedFactor (#23079)
* add CarParams.wheelSpeedFactor

* Fudge speed for Lexus RX

* should have been the TSS2 model

* bump cereal

* refactor into function

* update refs
2021-12-03 14:57:53 +01:00
sshane a0e5eccb70
Toyota: handle brake hold (#22810)
* disallow engagement if brake hold active

* we can check once

* move to common events

revert

* fix

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-08 14:26:30 -08:00
Willem Melching c4bac6bd68
Hyundai longitudinal prerequisites (#22121)
* panda

* bring over changes

* dont check car model

* remove comment

* fix typo

* more stuff gated behind long

* not

* not used

* gate that too

* try honda tuning

* clip accel values

* fix up merge

* fix stopping

* add retry logic around knockout

* increase timeout

* keep flipping lead bit

* true for now

* less tuning

* update comment

* 0.1 s is fine now

* merge honda and hyundai knockout

* more lead fields

* another obj bit

* increase timeout

* fix stopping flag

* only lag compensate for braking

* no lead

* less tuning

* only do knockout if not readonly

* try controlling using jerk

* tuning

* try higher stopping rate

* set stopping flag at higher speed

* clip upper jerk when stopping

* remove comments

* tester present 1hz

* use positive start accel

* 1.0 to maybe improve low speed stuff

* no point going over 0

* bump panda

* bump panda

* revert that change

* update ref
2021-09-13 22:03:08 -07:00
sshane 02772c69eb
Clean up Hyundai gear parsing (#21410)
* Use can definitions and refactor gear Hyundai parsing

* comment

* auto detect gearbox message

auto detect gearbox message

remove todos

remove todos

* comment

* Revert "comment"

This reverts commit 4b5129004e.

* Revert "auto detect gearbox message"

This reverts commit bcdf7c452d.

* no longer needed

* bump
2021-07-02 13:19:44 -07:00
Willem Melching 6729e963c9
Honda: emulate convenience blinker from stalk (#21387)
* Honda: emulate convenience blinker from stalk

* comment

* light->lamp

* reset on rising edge

* update ref
2021-06-29 12:10:35 +02:00
Greg Hogan e28b5552e7
hyundai: cruiseState.standstill always False when openpilot controls longitudinal (#21262) 2021-06-15 12:26:02 +02:00
ShaneSmiskol e7df9adfe3
2020 Ioniq PHEV Support (#21147)
* use DriverOverride

* keep using EMS16 msg which is available on manuals, TCS13 is not

* Need to differentiate between hybrid ev and ev

* bump opendbc

* add to release files

* try this

* try this

* fixup

* shouldn't need multiple dbc's

* update comments

* combine phev into ev_hybrid

* clean up

* accel_pedal_pos is a percent

* bump

* bump

* update list name

* do this in another PR

* not 2020+

* explicitly set safety param

* full hyundai gas press test coverage

* bump

* bump

* bump

* bump

* like this convention better

* bump

* revert some null gas_signal changes for now

* revert style change

* Add Ioniq PHEV 2020

* Use appropriate signals

* can't verify this to be true

* defaults

* order should really be opposite...

* original style

* bump panda

* bump

* update releases

* bump panda

* Update test route

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-10 23:25:02 -07:00
Jason Young 83ca5a0d29
Cleanup carstate quoting styles (#21109)
* carstate quoting style: VW

* carstate quoting style: Chrysler

* carstate quoting style: Ford

* carstate quoting style: GM

* carstate quoting style: Honda

* carstate quoting style: Hyundai

* carstate quoting style: Mazda

* carstate quoting style: Nissan

* carstate quoting style: Subaru

* carstate quoting style: Soulless Appliances

* Sorry Honda!
2021-06-02 15:51:54 +02:00
ShaneSmiskol 551091bcfa
Deprecate brakeLights field (#20954)
* remove all references to CS.brakeLights

* unused red

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-05-18 17:48:02 -07:00
Adeeb Shihadeh b0503e534a
Hyundai: add BSM detection (#20747)
* Hyundai: add BSM detection

* update refs
2021-04-25 13:12:03 -07:00
Adeeb Shihadeh 6c7ed8f2e4
enforce message checks in can parser (#20742)
* enforce message checks in can parser

* nissan

* vw

* hkg

* subaru

* toyota

* honda bosch

* gm

* honda nidec

* bump opendbc

* not all tss2 have bsm

* toyota fixes

* honda fixes

* vw fix

* fix subaru

* fix long tests

* update refs

* crv bsm
2021-04-25 12:52:16 -07:00
Greg Hogan 71654f141b
hyundai: update steer warning (#19628)
* update steer warning for hyundai

* hyundai: add CF_Mdps_ToiFlt to steerWarning
2021-04-10 18:29:57 -07:00
Adeeb Shihadeh 312b681a46
cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65eb.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
2021-02-16 21:39:32 -08:00
Greg Hogan 32b89fe30a
hyundai: car state with longitudinal control support (#19851) 2021-01-27 07:25:23 -08:00
Greg Hogan f205f97be0
hyundai: support for controlling cruise speed via HDA (#19635) 2021-01-12 11:50:08 -08:00
Adeeb Shihadeh 725e3b78ea
HKG fixups (#2342)
* fix hyundai blinker state

* consistency with update_speed

* update refs

* make hyundai resume reliable

* update refs

* 20 works

* don't need that

Co-authored-by: Greg Hogan <gregjhogan@gmail.com>
2020-10-14 18:27:27 -07:00
Adeeb Shihadeh 284938cd43 fix hyundai editing can parser values 2020-08-28 21:34:34 -07:00
Adeeb Shihadeh 059a27d126
Update Hyundai DBC (#1968)
* update for new DBC update

* update to new DBC

* Ioniq uses SCC12. Ioniq EV lim uses FCA11

* update elect gear to EV_PC5 signal

* remove 'alt' from label

* revert

* update name to ev_pc5_gears

* update name to use_ev_pc5_gears

* Update values.py

* Update carstate.py

* bump opendbc

Co-authored-by: xps-genesis <65239463+xps-genesis@users.noreply.github.com>
2020-08-02 15:19:27 -07:00
Adeeb Shihadeh e10376f1ae
Add frequency check to hyundai camera can parser (#1965) 2020-08-02 11:17:18 -07:00
Adeeb Shihadeh 892e1162c0
Car cleanup (#1924)
* cleanup car code

* more pruning

* little more

* less pylint disables

* radar stuff

* fix

* udpate refs

* fix honda bosch

* fix test
2020-07-25 15:07:27 -07:00
Adeeb Shihadeh 8bf198ba7d only check BSM on sonata for now, not equipped on all HKG 2020-07-09 18:26:06 -07:00
Adeeb Shihadeh 7cfdeb1a32
Hyundai: use SCC12 for stock ADAS signals on cars that don't have FCA11 (#1849)
* some hyundai use SCC12 for AEB/FCW

* add other cars from fingerprints

* comment
2020-07-09 17:52:48 -07:00
xps-genesis 57f29968a2
Add Hyundai BSM signals (#1782)
* Add Hyundai BSM signals

to take advantage of BSM to block lane change when BSM active.

* bug, added LCA11 to canparser

previous check failed, fixed by adding LCA11 to canparser

* update refs

Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
2020-06-26 12:16:06 -07:00
Adeeb Shihadeh 28b2495597
Hyundai stock adas signals (#1775)
* add stockAeb and stockFcw to carstate

* bump opendbc

* freq check

* bump opendbc
2020-06-24 14:55:58 -07:00
Adeeb Shihadeh 224672705c
Hyundai Ioniq EV LTD (#1694)
* add ioniq

* bump panda

* test route

* bump pnada
2020-06-15 11:45:37 -07:00
Adeeb 367155168a
Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
2020-06-03 16:13:34 -07:00
Adeeb Shihadeh 27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Adeeb Shihadeh efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Adeeb d9bf9f0a40
Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
2020-05-30 20:14:58 -07:00
Adeeb 337529d5cb
Add steerWarning and steerError to carState (#1444)
* Add steerWarning and steerError to carState

* fix gm and hyundai

* update refs
2020-05-01 13:13:12 -07:00
Willem Melching 94bba46d6d
Hyundai: use same gas pressed bit as in panda (#1428)
* use same bit as in panda

* remove lines

* update ref

* switch gas pedal signal
2020-04-27 15:28:34 -07:00
Willem Melching 7d78cef34b
Hyundai-Kia-Genesis (HKG) (#1362)
* hkg

* Cleanup

* Update readme

* more fixes and cleanup

* Old genesis

* Typoe

* Test car models

* Update comment

* Fix brake pressed

* Update release notes

* Fix vEgo

* Add sonata

* Add sonata values

* Temporarily remove doors check. It doesn't work

* Sonata uses crc8

* Fix tests

* Changes for LFA

* Add comment

* Does this improve the hud?

* Proper signal name

* Force the right value

* some ui stuff

* more comments

* Show lane lines on sonata

* cleanup dash

* fix last ui issues

* Fix doors

* update CI

Co-authored-by: Comma Device <device@comma.ai>
2020-04-15 19:33:24 -07:00
rbiasini a817d1c1e7
Hyundai: fix gas and gasPressed signals (#1152)
* Hyundai: fix gas and gasPressed signals

* upd panda

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-02-22 20:46:27 -08:00
rbiasini 9685a5a743
Abstract gasPressed for all cars (#1151)
* min_steer_speed alert (with adjusted hysteresis) for all cars, abstracted gas pre_enable event

* move lines a bit

* more GM cleanup

* typo

* move espDisabled to carState packet

* brought back min steer speed alert only in hyundai. It's a bit tricky and behavior should be changed

* ops, wrong change

* bug

* update cereal

* update ref
2020-02-21 18:24:37 -08:00
Adeeb e8cb6ea06a
Abstract common events + event cleanup (#1129)
* too many if

* unused

* whitespace

* key

* sefldrive/car/*

* no more gctx

* lower

* start abstracting common events

* all cars

* start small

* all cars

* reverse gear

* wrongCarMode

* wrongGear

* espDisabled

* steerUnvailable

* make linter happy

* c isn't used

* fix esp_disabled in VW

* update ref

* more red

* more cleanup

* fix subaru

* update ref
2020-02-20 16:22:25 -08:00
rbiasini dc3ea9b08d
get_can_parser and get_cam_can_parser are now standard static methods (#1136) 2020-02-20 13:08:43 -08:00
rbiasini 0c67143c92
Carstate returns capnp struct (#1115)
* Before abstraction, adding speed init from VW as well

* strting to abstract carstate class

* fix bug and update lock?

* revert pipfile change

* another bug

* fix linter

* bug fix

* remove a bunch of diplicated kf code

* better to not have class vars. will abstract __init__ anyway later

* abstract common instance vars in carstate init and a generic gear parser static method

* abstract gear parser for chrysler

* abstract gm gear parser too

* remove unnecessary random vars

* Chrysler: carstate returns capnp struct directly

* revert ref commit

* test ref

* WIP

* more WIP

* ops, missed this conflict

* ford as well

* not sure why this got deleted

* no need to copy

* remove copy

* remove copy import

* remove unnecessary intermediate variable

* remove obsolete comments

* GM: have carstate returning capnp struct directly

* Honda carstate also outputing capnp struct

* hyundai too now returns capnp from carstate

* ops, not meant this

* Subaru carstate also returning capnp

* Toyota: capnp struct as output of carstate

* fix bool

* minor simplififcation in Honda

* no need to negate

* VW carstate returning capnp struct (#1118)

* VW carstate also returning capnp struct

* fixed typo

* Remove unused blinker button (#1119)

* remove unused blinker button

* ops, this wasn't meant

* remove blinker button for VW as well

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-02-18 15:28:15 -08:00
rbiasini bfa79153b4
Ford: have carstate update returning capnp struct directly (#1113)
* Before abstraction, adding speed init from VW as well

* strting to abstract carstate class

* fix bug and update lock?

* revert pipfile change

* another bug

* fix linter

* bug fix

* remove a bunch of diplicated kf code

* better to not have class vars. will abstract __init__ anyway later

* abstract common instance vars in carstate init and a generic gear parser static method

* abstract gear parser for chrysler

* abstract gm gear parser too

* remove unnecessary random vars

* Chrysler: carstate returns capnp struct directly

* revert ref commit

* test ref

* WIP

* more WIP

* ops, missed this conflict

* ford as well

* not sure why this got deleted

* no need to copy

* remove copy

* remove copy import

* remove unnecessary intermediate variable

* remove obsolete comments

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-02-17 14:42:41 -08:00
rbiasini 5c52be27ca
abstract kf and gear parser as static methods (#1103)
* Before abstraction, adding speed init from VW as well

* strting to abstract carstate class

* fix bug and update lock?

* revert pipfile change

* another bug

* fix linter

* bug fix

* remove a bunch of diplicated kf code

* better to not have class vars. will abstract __init__ anyway later

* Abstract gear parser static method (#1107)

* abstract common instance vars in carstate init and a generic gear parser static method

* update opendbc (#1105)

* abstract gear parser for chrysler

* update opendbc (#1106)

* abstract gm gear parser too

* remove unnecessary random vars
2020-02-17 11:53:53 -08:00
George Hotz 71ead9adea selfdrive/car 2020-01-17 10:58:43 -08:00