Commit Graph

46 Commits (628eecff06595395f9d5166e82680dc1a2c58af7)

Author SHA1 Message Date
Shane Smiskol 628eecff06
CARS.md tweaks (#23983)
* CARS.md fixups

* wrong one

* sort footnotes

* Mazda CX-9 has good torque

* Try this

* generate

* yup, os uses native filesystem order
2022-03-17 16:11:03 -07:00
Shane Smiskol 31a6b141d6
Docs: auto-generate supported cars documentation (#23762)
* make CAR class enum, and values.py formatting

* Revert "make CAR class enum, and values.py formatting"

This reverts commit 04d9817e9d.

* stash

* add supported packages and model years

* don't change model years in fps

* move Lexus to info dict and make int enum

* remove sometimes wrong model years from name string

* use enum names

* convert Honda's values

* nice names

* use name

* GM

* Mazda, Ford

* Hyundai: WIP

* finish Hyundai

* fix

* Nissan

* Subaru

* Tesla

* formatting is for another PR

* Chrysler: todo: unify the Pacificas?

* do volkswagen

* this isn't a zoo

* skip enums for now

* Update selfdrive/car/volkswagen/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

* set All

* temp cars

* auto-generate CARS.md

* update type hinting

* add generated file

* add longitudinal star to cars that support disabling radar

* add TODO

* add notes

* add min_steer_speed exception for hatchback

* add minimum steering speeds

* Add exceptions and run generator

* Missing Telluride

* fix Prius v

* missing Prius Prime

generate

* start to convert years to strings

* Fixup Hyundai

* convert year sets to strings

* handle this

* missing S3

* Fix and add all missing cars (verified with script

* Supported Package fixes

* add get_tiered_cars

* Check radarOffCan for removing most Honda from op long

* Update for Avalon stop and go update on master

* Fix missing car params

* add my temporary script i'm using to verify new generated DBC

add my temporary script i'm using to verify new generated DBC

* generate with jinja template

* add header and footer

* clean up

* rename

rename

* add exceptions. jinja is nice, but why are its loop indexes starting at 1?

* add list of known car videos

* See how these look

* Add nice table formatting for column description

Add nice table formatting for column description

* generate

* consisten br tag

* small clean up

* temp

* Move car videos into CarInfo

* add new copy and rename to footnotes

* Revert "temp"

This reverts commit 93c3fce1d3.

clean up

* generate

* replace with svg

* simplify a bit

* add footnotes to CarInfo

* move some variables to docs.py

* Add video link for Acadia

* Make Footnote an enum so we don't use random ints

* static analysis fixes

* move to CARS.md

* fix last missing footnote

* add to release files

* rm test file

* use svg

generate

* fix sorting

* not needed

* not sure how this got here

* remove Sedan/Couple and add Diesel footnote

* finish todos

* move make specific footnotes to selfdrive/car/*/values.py

rename

* change to zeros

* align bottom to center

* Apply some suggestions

* Update selfdrive/car/mock/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update copy

* Try headers + bullet points

* somehow better

somehow better

* finish updating copy

* move template and add links to sups

* stars shouldn't be clickable

that didn't work

try this

try this

this is better

* add type hints to CarInfo

add more type hinting

* optional needs a type and any covers all (?)

* move good steering torque to */values.py

* dataclasses are much nicer than attr

* use tuple

* Update docs/cars.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* suggestions

* suggestions

* suggestions

remove

* clean up a bit

* add more type hints

* center stars and remove hardcoding from template

* update copy

* Add test

* Fix types

Fix types

* add supported cars documentation test

* clean up

* replace with docs_definitions

* Add back Footnote enums

* Ah so these are like fstrings!

* Update selfdrive/car/CARS_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update year from master merge

* Fix longitudinal star from merge

* sort properly stars by Column enum

* clean up

* HKG: Sorry guys

* Prius V gets FSR star, like others

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update comment

* No Prius docs change for now

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-16 21:27:05 -07:00
Adeeb Shihadeh bae78dd46b
don't read params in car interfaces (#23978) 2022-03-16 15:17:47 -07:00
Dean Lee a186bcc9f1
cleanup iterate keys in dictionaries (#23497) 2022-01-12 12:42:50 +01:00
Dean Lee a653461dec
check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2022-01-10 16:36:51 +01:00
Ewout ter Hoeven 332f568a82
Pyupgrade 3.6: Update syntax with Python 3.6+ features (#23305)
Updated Python code with Python 3.6+ features:
- utf-8 encoding is now the default (PEP 3120)
- Replace list comprehensions by Generator Expressions (PEP 289)
- Replace yield loop by yield from (PEP 380)
- Remove the (object) subclass when defining a class
- Replace the IOError alias by OSError (PEP 3151)
- Define sets with curly braces {} instead of set()
- Remove "r" parameter from open function, which is default

Co-Authored-By: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-Authored-By: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>

Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-authored-by: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>
2021-12-24 11:18:39 -08:00
Ewout ter Hoeven 55390d273f
Convert format strings strings to f-strings (#23241)
* Convert all text strings to f-strings

Reformats all the text from the old "%-formatted" and .format(...) format to the newer f-string format, as defined in PEP 498. This requires Python 3.6+.

Flynt 0.69 was used to reformat the strings. 120 f-strings were created in 51 files.

F-strings are in general more readable, concise and performant. See also: https://www.python.org/dev/peps/pep-0498/#rationale

* revert pyextra changes

* revert ublox.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-12-16 14:58:17 +01:00
Shane Smiskol b745a14ff7
version.py: make function names more clear (#23216)
* rename a few version functions

* and is_prebuilt

* and some formatting 😊
2021-12-14 12:15:13 +01:00
Willem Melching f7c46c6949
Do not run code on version.py import (#23063)
* Do not run code on version.py import

* fix athena
2021-11-29 19:38:55 +01:00
Adeeb Shihadeh d8f5e8b7a4
remove toyota can fingerprinting exceptions (#22803)
* remove toyota can fingerprinting exceptions

* cleanup
2021-11-05 13:49:30 -07:00
Robbe Derks 6bef60ddf5
extend fingerprint for multipanda ports (#22798) 2021-11-05 13:17:27 +01:00
Willem Melching 88d248a5af
Remove fuzzy fingerprint startup alert (#22328)
* deprecate fuzzy fingerprint startup alert

* bump cereal
2021-09-23 17:15:33 -07:00
Adeeb Shihadeh 7546608eb0 add fw version count to fingerprint cloudlog 2021-07-13 14:00:02 -07:00
Adeeb Shihadeh d4ab1f1e27
startup alert for no fw returned (#21177) 2021-06-07 14:15:09 -07:00
Jason Young 182b00896c
Update CI tests for CAN fingerprinting deprecation (#21043)
* Start refactor of CI tests for FPv1 deprecation

* Fix test_car_interfaces

* Touch up comment

* Smaller diff
2021-05-26 14:02:42 -07:00
Adeeb Shihadeh f08e01c97f
fingerprint cloudlog event (#20950)
* fingerprint cloudlog event

* kale cloudlog

* not fuzzy
2021-05-18 10:52:53 -07:00
Adeeb Shihadeh a7d4cf6e39
Fix VW trans type detection (#20716) 2021-04-20 14:49:58 -07:00
Willem Melching e4f73fbda5
Fuzzy match on ECU FW versions (#20687)
* Fuzzy match on 3+ ECUs

* reuse dict

* exclude some shared ecus to be sure

* show alert for fuzzy match

* use title case

* require community toggle

* refactor

* do both exact and fuzzy in test script

* update test script

* add fuzz test and lower matches to >= 2

* strip alert length

* sort mismatches

* add fw tests to test_startup

* bump cereal
2021-04-20 12:00:36 +02:00
Adeeb Shihadeh 07ab081a42
oneplus cleanup (#20200)
* start cleanup

* cleanup camerad

* remove unused

* little more

Co-authored-by: Comma Device <device@comma.ai>
2021-03-01 17:14:03 -08:00
Adeeb Shihadeh 8674b023ba
HW abstraction layer (#19530)
* start hw refactor

* move that

* pins

* put that back
2020-12-16 21:30:23 -08:00
Adeeb Shihadeh 6a151dcd9c
oneplus deprecation (#2748)
* oneplus deprecation

* lowercase

* too long

* no udpates
2020-12-12 12:51:12 -08:00
Jon Ander Oribe 887d67eb8d
Simple improvements for quality gate (#2517)
* Improvements for quality gate

* Update test_xattr.py

* Update test_mpc_wobble.py

* python

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-11-12 14:48:45 -08:00
Adeeb Shihadeh 47c21f10f5
grey panda is unsupported (#2458) 2020-11-03 19:56:25 -08:00
Adeeb Shihadeh d92ec9642e
grey panda deprecation (#2406) 2020-10-26 23:09:06 -07:00
Adeeb Shihadeh 714f8c3f0b
Remove get_one_can from messaging (#1946)
* move get_one_can into openpilot

* bump cereal
2020-07-28 23:52:18 -07:00
Adeeb Shihadeh ccf6b80c7e
Cleanup startup event handling (#1748)
* cleanup startup event

* always show permanent

* lowest

* update refs
2020-06-19 16:16:48 -07:00
Willem Melching 106cddb49a White panda no longer supported 2020-05-31 13:33:56 -07:00
Willem Melching bb8bbdd9ee
Hyundai fw query (#1540)
* hyundai fw query

* Change query

* this works

* That is not engine

* hyundai fw query

* Change query

* this works

* That is not engine

* Skip FW query in test_car_models

* Those routes don't fingerprint properly after speedup

* only send toyota queries to subaddresses

Co-authored-by: openpilot laptop <laptop@comma.ai>
2020-05-19 13:43:44 -07:00
Willem Melching c85b174584
White panda is deprecated (#1516)
* Start white panda deprecation

* Unify alert text

* Add noentry

* Change to no longer supported

* panda is lowercase

* Capitalize

* rerun ci
2020-05-15 13:00:00 -07:00
Adeeb d976233f69
Alerts + Events refactor (#1466) 2020-05-14 15:21:21 -07:00
Willem Melching 5d69e97281 Less hardcoded values in profiling script 2020-05-01 11:38:30 -07:00
Willem Melching 0112a8d3fd Fix dashcam missing CarState 2020-04-01 16:36:46 -07:00
Andrew Chan 5e9daf2471
Adding error checking to only use the cached fp if they're valid (#1182) 2020-03-02 09:04:49 -08:00
Adeeb 796d5c8cca
Process replay enhancements (#1153)
* process replay: exclude processes and cars
2020-02-26 11:31:27 -08:00
Willem Melching 348bd15345 Add log when starting VIN query 2020-02-24 13:40:18 -08:00
Willem Melching 449d7a2efa Don't use cache if mock 2020-02-24 13:34:33 -08:00
rbiasini dc3ea9b08d
get_can_parser and get_cam_can_parser are now standard static methods (#1136) 2020-02-20 13:08:43 -08:00
Willem Melching 9e6e1cba56
Fingerprint rav4 hybrid tss2 only using firmware versions (#1084)
* fingerprint rav4 hybrid tsss only using firmware

* remove print statement
2020-02-12 12:59:38 -08:00
Willem Melching b7aeb5d64d
Cache FW query (#1025)
* split fw query and matching

* Read cached firmware versions

* add tests

* this works
2020-01-30 17:57:20 -08:00
Willem Melching a053244a5a log fingerprint source 2020-01-30 14:39:26 -08:00
Willem Melching 356f353489
FW fingerprint for Honda & Toyota (#961)
* add script to process logs

* Skip rav4 ESP

* Improve gathering script

* Update firmware versions for honda and toyota

* more firmware versions

* If FW query returns 1 candidate, use it

* Add FW versions

* Fix COROLLA_TSS2 two enigine addresses

* uncomment rav4h tss2

* add progress bar to test script

* Batch with more ecu versions
2020-01-30 14:32:26 -08:00
Willem Melching 65a40149d8 startup alert, handle case where param returns none 2020-01-17 21:30:14 -08:00
George Hotz c7bc8ee00f python 3 issue 2020-01-17 17:50:43 -08:00
George Hotz dcd0807d7e whitelist, don't blacklist 2020-01-17 17:46:17 -08:00
George Hotz 013166a34e add alert 2020-01-17 17:46:17 -08:00
George Hotz 71ead9adea selfdrive/car 2020-01-17 10:58:43 -08:00