Commit Graph

259 Commits (master)

Author SHA1 Message Date
Adeeb Shihadeh 8af20af66d
pylint: enforce indentation (W0311) (#24039)
* pylint: enforce indentation (W0311)

* few more
2022-03-24 23:23:29 -07:00
Shane Smiskol c88ced1f10
Honda Nidec: don't actuate while longitudinal is inactive (#24028)
* don't command any pcm_speed when long is not active

* update refs
2022-03-23 18:30:05 -07:00
Shane Smiskol 70286766da
Honda: clean up CarInterface.apply and CarController (#23876)
* clean up honda/carcontroller

* indentation

* fixes

* clean up apply function

clean up apply function
2022-03-18 19:10:59 -07:00
Adeeb Shihadeh 2219cb4478
cars: cleanup CS usage (#23957) 2022-03-18 15:39:22 -07:00
Shane Smiskol 31a6b141d6
Docs: auto-generate supported cars documentation (#23762)
* make CAR class enum, and values.py formatting

* Revert "make CAR class enum, and values.py formatting"

This reverts commit 04d9817e9d.

* stash

* add supported packages and model years

* don't change model years in fps

* move Lexus to info dict and make int enum

* remove sometimes wrong model years from name string

* use enum names

* convert Honda's values

* nice names

* use name

* GM

* Mazda, Ford

* Hyundai: WIP

* finish Hyundai

* fix

* Nissan

* Subaru

* Tesla

* formatting is for another PR

* Chrysler: todo: unify the Pacificas?

* do volkswagen

* this isn't a zoo

* skip enums for now

* Update selfdrive/car/volkswagen/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

* set All

* temp cars

* auto-generate CARS.md

* update type hinting

* add generated file

* add longitudinal star to cars that support disabling radar

* add TODO

* add notes

* add min_steer_speed exception for hatchback

* add minimum steering speeds

* Add exceptions and run generator

* Missing Telluride

* fix Prius v

* missing Prius Prime

generate

* start to convert years to strings

* Fixup Hyundai

* convert year sets to strings

* handle this

* missing S3

* Fix and add all missing cars (verified with script

* Supported Package fixes

* add get_tiered_cars

* Check radarOffCan for removing most Honda from op long

* Update for Avalon stop and go update on master

* Fix missing car params

* add my temporary script i'm using to verify new generated DBC

add my temporary script i'm using to verify new generated DBC

* generate with jinja template

* add header and footer

* clean up

* rename

rename

* add exceptions. jinja is nice, but why are its loop indexes starting at 1?

* add list of known car videos

* See how these look

* Add nice table formatting for column description

Add nice table formatting for column description

* generate

* consisten br tag

* small clean up

* temp

* Move car videos into CarInfo

* add new copy and rename to footnotes

* Revert "temp"

This reverts commit 93c3fce1d3.

clean up

* generate

* replace with svg

* simplify a bit

* add footnotes to CarInfo

* move some variables to docs.py

* Add video link for Acadia

* Make Footnote an enum so we don't use random ints

* static analysis fixes

* move to CARS.md

* fix last missing footnote

* add to release files

* rm test file

* use svg

generate

* fix sorting

* not needed

* not sure how this got here

* remove Sedan/Couple and add Diesel footnote

* finish todos

* move make specific footnotes to selfdrive/car/*/values.py

rename

* change to zeros

* align bottom to center

* Apply some suggestions

* Update selfdrive/car/mock/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update copy

* Try headers + bullet points

* somehow better

somehow better

* finish updating copy

* move template and add links to sups

* stars shouldn't be clickable

that didn't work

try this

try this

this is better

* add type hints to CarInfo

add more type hinting

* optional needs a type and any covers all (?)

* move good steering torque to */values.py

* dataclasses are much nicer than attr

* use tuple

* Update docs/cars.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* suggestions

* suggestions

* suggestions

remove

* clean up a bit

* add more type hints

* center stars and remove hardcoding from template

* update copy

* Add test

* Fix types

Fix types

* add supported cars documentation test

* clean up

* replace with docs_definitions

* Add back Footnote enums

* Ah so these are like fstrings!

* Update selfdrive/car/CARS_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update year from master merge

* Fix longitudinal star from merge

* sort properly stars by Column enum

* clean up

* HKG: Sorry guys

* Prius V gets FSR star, like others

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update comment

* No Prius docs change for now

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-16 21:27:05 -07:00
Adeeb Shihadeh bae78dd46b
don't read params in car interfaces (#23978) 2022-03-16 15:17:47 -07:00
Adeeb Shihadeh 20db4525a2
Fix controls mismatch on button enable cars + test against panda safety (#23975)
* test models: check button enable cars against panda safety

* gm too

* cleanup
2022-03-16 14:54:22 -07:00
Adeeb Shihadeh ae19308e83
add parkingBrake to carState (#23968)
* add parkingBrake to carState

* fix gm
2022-03-14 16:32:20 -07:00
Adeeb Shihadeh 5c3f3e44bc
break up selfdrive.config (#23959)
* break up selfdrive.config

* add to release files

* fix import order
2022-03-13 21:42:39 -07:00
Shane Smiskol 629399a449
carControl: add long and lat active fields (#23859)
* proof of concept

* actuators packet describes which actuators are active

* bump cereal

* fixes

* not needed for this PR

* Do Toyota

* add back controlsState.active

* bump cereal

* rest of cars

* in actuators

* add active back

* which

* use controlsState.active for now

* will make an issue

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move local lat_active checks into CC.latActive

* remove redundant checks

* move comment

move comment

* fix joystick mode

* get enabled from carcontrol

* do standstill check in controlsd

* make sure we consider the gas press case for GM

* use CC.actuators

* fix

* capitalization

* Bump cereal

Bump cereal

* make intermediate actuators

* similar convention to before

* clean that up

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-13 20:58:44 -07:00
Adeeb Shihadeh 6ff643c478
Honda: remove redundant steer fault check (#23920) 2022-03-07 10:37:23 -08:00
Adeeb Shihadeh 87849f93b1
better steer fault names (#23890)
* better steer fault names

* bump cereal
2022-03-01 22:53:55 -08:00
Shane Smiskol 31228ce560
Honda: use common DBC for CRV H and Accord Diesel (#23743)
* bump

* use Accord DBC for CRVH, Civic Diesel

* bump

* bump opendbc
2022-02-12 16:28:53 -08:00
Shane Smiskol 209bfe536b
Honda: fix brake pressed signal (#23683)
* or brake_switch

* remove car exceptions

* Revert "remove car exceptions"

This reverts commit cad6a552aa4a17c69616014d3e9333d30c1fadd3.

* does have ts noise, use updated

* bump panda for tests

* bump

* messsssy draft

* clean up

* clean up

* bump

* CS: process all messages at once, like we do during real openpilot usage

* handle multiple messages updated in one cycle

* bump

* bump

* use less confusing, but equivalent cp.vl

* Update selfdrive/test/test_models.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* no msg

* bump opendbc

* Update selfdrive/car/honda/carstate.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* same test logic

* add brake_switch_prev to class

* need to set previous brake switch when not lagging (most of the time)

* need to compare

* only update previous if updated this cycle

rm

* need to maintain previous active state

* move brake_switch

* bump opendbc

* bump

* bump

* bump

* bump

* bump

* bump

* bump opendbc

* rename

* oops

* bump opendbc

* bump

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-02-10 13:04:37 -08:00
Shane Smiskol 61de3788ff
CANParser: remove rest of default values (#23676)
* forgot honda somehow!

* forgot some more signal defaults
2022-01-31 17:29:55 -08:00
Willem Melching 96743c1067
Honda Pilot, Passport, Ridgeline: increase user brake threshold (#23641) 2022-01-30 19:45:24 +01:00
Adeeb Shihadeh d2735d73fc
test car models: fix all panda safety mismatches (#23616)
* remove tolerance

* fix nissan mismatches

* warm up

* remove additional bosch check

* another honda exception

* little more

* Update selfdrive/test/test_models.py
2022-01-29 22:14:27 -08:00
Shane Smiskol a584436328
Honda: use common DBC for PILOT and others (#23659)
* use common dbc

* bump

* remove from files common
2022-01-28 22:26:18 -08:00
Adeeb Shihadeh 8eb6a6a535
Honda: no actuation while in pre-enabled state (#23657)
* Honda: no actuation in pre-enabled state

* Honda: no actuation while in pre-enabled state
2022-01-28 15:28:17 -08:00
Adeeb Shihadeh 2aa2031352 Honda: minor carState cleanup 2022-01-28 14:29:40 -08:00
Shane Smiskol 95caa5f399
CANParser: consistent style for adding signals/checks (#23646)
* consistent style, like toyota

* typo
2022-01-28 13:20:13 -08:00
vanillagorillaa 06541abddc
Honda: Merge Passport interface (#23651) 2022-01-27 20:16:13 -08:00
Shane Smiskol 3645186d7c
CANParser: remove default values (#23642)
* draft

* remove rest

* bump

* update radar interfaces

* do rest and formatting

* bump

* fix mising check

* try this

* Revert "try this"

This reverts commit 0d26d9a072.

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-01-27 17:06:18 -08:00
vanillagorillaa 4f827e2e9e
Honda: Merge Pilot_2019 into Pilot (#23590)
* merge pilot

* these weren't on the 2019 pilot

* add non essential ECUs
2022-01-24 21:19:40 -08:00
Adeeb Shihadeh 3e9cb7fa12
remove community features toggle (#23214)
* remove community features toggle

* bump cereal

* little more

* update refs
2022-01-24 14:49:47 -08:00
Adeeb Shihadeh 5b2d2f31ef Honda: use Pilot DBC for Ridgeline 2022-01-19 22:11:21 -08:00
Dean Lee a653461dec
check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2022-01-10 16:36:51 +01:00
Shane Smiskol cf9792dc53
Longcontrol: remove starting state (#23328)
* remove starting state

* new ref

* ready for merge

* try this

* cereal now on master

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
2022-01-04 15:40:39 -08:00
Dean Lee 05b905d140
interfaces/apply: follow capnp best practices (#23371) 2022-01-04 11:34:49 +01:00
Anthony Foerster 1ca5e1c82b
Fix steering oscillations in 2019 RDX (#22677)
Steering wheel would oscillate quickly when going straight, oscillation
is gone after this modification.
2022-01-03 23:07:49 -08:00
Ewout ter Hoeven 332f568a82
Pyupgrade 3.6: Update syntax with Python 3.6+ features (#23305)
Updated Python code with Python 3.6+ features:
- utf-8 encoding is now the default (PEP 3120)
- Replace list comprehensions by Generator Expressions (PEP 289)
- Replace yield loop by yield from (PEP 380)
- Remove the (object) subclass when defining a class
- Replace the IOError alias by OSError (PEP 3151)
- Define sets with curly braces {} instead of set()
- Remove "r" parameter from open function, which is default

Co-Authored-By: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-Authored-By: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>

Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-authored-by: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>
2021-12-24 11:18:39 -08:00
HaraldSchafer cf466222f6
Road Roll Compensation Rebased (#23251)
* first commit

* update refs
2021-12-16 17:34:12 -08:00
Ewout ter Hoeven 55390d273f
Convert format strings strings to f-strings (#23241)
* Convert all text strings to f-strings

Reformats all the text from the old "%-formatted" and .format(...) format to the newer f-string format, as defined in PEP 498. This requires Python 3.6+.

Flynt 0.69 was used to reformat the strings. 120 f-strings were created in 51 files.

F-strings are in general more readable, concise and performant. See also: https://www.python.org/dev/peps/pep-0498/#rationale

* revert pyextra changes

* revert ublox.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-12-16 14:58:17 +01:00
Willem Melching 4f1eb4278a
Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
2021-12-16 13:08:20 +01:00
Adeeb Shihadeh 1638975627
Merge 2021 Accords into 2018 Accords (#23174)
* Merge 2021 Accords into 2018 Accords

* last of them
2021-12-08 14:40:14 -08:00
Willem Melching 0ec68a5a09
0.8.11-release FW batch (#23167)
* 0.8.11-release FW batch

* those toyota also dont always return esp

* attempt to clean up 2018 & 2021 accord
2021-12-08 14:44:00 +01:00
Adeeb Shihadeh 0283942a95
Honda: use new Bosch LKAS_HUD messages (#23000)
* Honda: use new Bosch LKAS_HUD messages

* enum value

* better name

* flip that
2021-12-05 13:51:33 -08:00
Chris McCammon 9e51befe18
Honda Pilot fw (#23119) 2021-12-03 16:11:15 -08:00
Willem Melching e6180738fd
add CarParams.wheelSpeedFactor (#23079)
* add CarParams.wheelSpeedFactor

* Fudge speed for Lexus RX

* should have been the TSS2 model

* bump cereal

* refactor into function

* update refs
2021-12-03 14:57:53 +01:00
Adeeb Shihadeh 239c7c1d4e
Bring back Accord 2021 + 2021 Hybrid (#23021)
Co-authored-by: Chris Souers <csouers@gmail.com>
2021-11-23 23:19:11 -08:00
Adeeb Shihadeh 7746130a1e
Honda Bosch cleanup (#22999) 2021-11-21 14:52:35 -08:00
Adeeb Shihadeh b07ddad6ed comma pedal: rename create_gas_command -> create_gas_interceptor_command 2021-11-20 20:13:58 -08:00
Brett Sanderson 8b25551c7f
Honda: rename HONDA_NIDEC_ALT_MAIN to HONDA_PARAM_NIDEC_ALT_SCM_MESSAGES (#22970)
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-18 14:52:37 -08:00
Adeeb Shihadeh 14651866c2
Honda: handle ACC state consistent with ISO 15622:2018 (#22958) 2021-11-17 17:30:50 -08:00
Adeeb Shihadeh 70c1f19304
pedal: only send command while actuators active (#22942) 2021-11-16 22:38:23 -08:00
Willem Melching 8a8cee5e54
Batch of ECU FW from cars that fuzzy fingerprinted (#22883)
* honda

* hyundai

* toyota

* VW
2021-11-12 16:31:29 +01:00
Adeeb Shihadeh 8933859e35
Remove remaining Toyota + Honda CAN fingerprints (#22827) 2021-11-08 14:37:25 -08:00
sshane a0e5eccb70
Toyota: handle brake hold (#22810)
* disallow engagement if brake hold active

* we can check once

* move to common events

revert

* fix

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-08 14:26:30 -08:00
justinmccaffrey 28e16c7b84
Add 2021 Honda Passport (#22781)
* update values.py

* add passport to carstate, interface, values

* add a test route with mostly green

* switch to newer route

* update readme

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-11-04 15:28:04 +01:00
Adeeb Shihadeh c85c8fee3c
Remove CAN fingerprints + FW dump (#22647)
* add missing pilot fw

* toyotas

* camry hybrid
2021-10-20 23:12:04 -07:00